Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: src/mips/builtins-mips.cc

Issue 1643973002: MIPS: Refine '[builtins] Make Math.max and Math.min fast by default.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix 64-bit port. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/mips64/builtins-mips64.cc » ('j') | src/mips64/builtins-mips64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mips/builtins-mips.cc
diff --git a/src/mips/builtins-mips.cc b/src/mips/builtins-mips.cc
index a8a8293de7f42d0acdc149d4e7c971d1c5e1dc22..91feaf58cc9b6eb4ee1665e4cb911528983e2827 100644
--- a/src/mips/builtins-mips.cc
+++ b/src/mips/builtins-mips.cc
@@ -166,11 +166,10 @@ void Builtins::Generate_MathMaxMin(MacroAssembler* masm, MathMaxMinKind kind) {
{
// Check if all parameters done.
__ Subu(a0, a0, Operand(1));
- __ Branch(USE_DELAY_SLOT, &done_loop, lt, a0, Operand(zero_reg));
+ __ Branch(&done_loop, lt, a0, Operand(zero_reg));
// Load the next parameter tagged value into a2.
- __ sll(at, a0, kPointerSizeLog2); // In delay slot
- __ Addu(at, at, sp);
+ __ Lsa(at, sp, a0, kPointerSizeLog2);
__ lw(a2, MemOperand(at));
// Load the double value of the parameter into f2, maybe converting the
@@ -238,8 +237,7 @@ void Builtins::Generate_MathMaxMin(MacroAssembler* masm, MathMaxMinKind kind) {
}
__ bind(&done_loop);
- __ sll(a3, a3, kPointerSizeLog2);
- __ addu(sp, sp, a3);
+ __ Lsa(sp, sp, a3, kPointerSizeLog2);
__ mov(v0, a1);
__ DropAndRet(1);
}
« no previous file with comments | « no previous file | src/mips64/builtins-mips64.cc » ('j') | src/mips64/builtins-mips64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698