MIPS: Refine '[builtins] Make Math.max and Math.min fast by default.'

src/mips/builtins-mips.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_MIPS
 
 #include "src/codegen.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/full-codegen/full-codegen.h"
@@ skipping 148 matching lines @@
   // +Infinity), with the tagged value in a1 and the double value in f0.
   __ LoadRoot(a1, root_index);
   __ ldc1(f0, FieldMemOperand(a1, HeapNumber::kValueOffset));
   __ mov(a3, a0);
 
   Label done_loop, loop;
   __ bind(&loop);
   {
     // Check if all parameters done.
     __ Subu(a0, a0, Operand(1));
-    __ Branch(USE_DELAY_SLOT, &done_loop, lt, a0, Operand(zero_reg));
+    __ Branch(&done_loop, lt, a0, Operand(zero_reg));
 
     // Load the next parameter tagged value into a2.
-    __ sll(at, a0, kPointerSizeLog2);  // In delay slot
-    __ Addu(at, at, sp);
+    __ Lsa(at, sp, a0, kPointerSizeLog2);
     __ lw(a2, MemOperand(at));
 
     // Load the double value of the parameter into f2, maybe converting the
     // parameter to a number first using the ToNumberStub if necessary.
     Label convert, convert_smi, convert_number, done_convert;
     __ bind(&convert);
     __ JumpIfSmi(a2, &convert_smi);
     __ lw(t0, FieldMemOperand(a2, HeapObject::kMapOffset));
     __ JumpIfRoot(t0, Heap::kHeapNumberMapRootIndex, &convert_number);
     {
@@ skipping 22 matching lines @@
     }
     __ jmp(&convert);
     __ bind(&convert_number);
     __ ldc1(f2, FieldMemOperand(a2, HeapNumber::kValueOffset));
     __ jmp(&done_convert);
     __ bind(&convert_smi);
     __ SmiToDoubleFPURegister(a2, f2, t0);
     __ bind(&done_convert);
 
     // Perform the actual comparison with the accumulator value on the left hand
-    // side (d1) and the next parameter value on the right hand side (d2).
+    // side (f0) and the next parameter value on the right hand side (f2).
     Label compare_equal, compare_nan, compare_swap;
     __ BranchF(&compare_equal, &compare_nan, eq, f0, f2);
     __ BranchF(&compare_swap, nullptr, cc, f0, f2);
     __ Branch(&loop);
 
     // Left and right hand side are equal, check for -0 vs. +0.
     __ bind(&compare_equal);
     __ FmoveHigh(t0, reg);
     __ Branch(&loop, ne, t0, Operand(0x80000000));
 
     // Result is on the right hand side.
     __ bind(&compare_swap);
     __ mov_d(f0, f2);
     __ mov(a1, a2);
     __ jmp(&loop);
 
     // At least one side is NaN, which means that the result will be NaN too.
     __ bind(&compare_nan);
     __ LoadRoot(a1, Heap::kNanValueRootIndex);
     __ ldc1(f0, FieldMemOperand(a1, HeapNumber::kValueOffset));
     __ jmp(&loop);
   }
 
   __ bind(&done_loop);
-  __ sll(a3, a3, kPointerSizeLog2);
-  __ addu(sp, sp, a3);
+  __ Lsa(sp, sp, a3, kPointerSizeLog2);
   __ mov(v0, a1);
   __ DropAndRet(1);
 }
 
 // static
 void Builtins::Generate_NumberConstructor(MacroAssembler* masm) {
   // ----------- S t a t e -------------
   //  -- a0                     : number of arguments
   //  -- a1                     : constructor function
   //  -- ra                     : return address
@@ skipping 2525 matching lines @@
   }
 }
 
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_MIPS