Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1643963002: skiaserve: Clean up flags. (Closed)

Created:
4 years, 10 months ago by jcgregorio
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skiaserve: Clean up flags. Remove unused flags. Add --port and --source. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643963002 Committed: https://skia.googlesource.com/skia/+/21ab1209f5a1ccfcb48ae41965245024bacdf848

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M tools/skiaserve/skiaserve.cpp View 1 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jcgregorio
4 years, 10 months ago (2016-01-28 13:38:49 UTC) #3
joshualitt
On 2016/01/28 13:38:49, jcgregorio wrote: lgtm
4 years, 10 months ago (2016-01-28 14:06:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643963002/20001
4 years, 10 months ago (2016-01-28 14:09:57 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 14:24:22 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/21ab1209f5a1ccfcb48ae41965245024bacdf848

Powered by Google App Engine
This is Rietveld 408576698