Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4841)

Unified Diff: chrome/browser/cocoa/download_request_dialog_delegate_mac.mm

Issue 164391: Implement http auth login dialog for OS X. (Closed)
Patch Set: re-disable nonfuntional test Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/constrained_window_mac.mm ('k') | chrome/browser/login_prompt_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/download_request_dialog_delegate_mac.mm
diff --git a/chrome/browser/cocoa/download_request_dialog_delegate_mac.mm b/chrome/browser/cocoa/download_request_dialog_delegate_mac.mm
index 3a34940932cfa7ffc2000e6e3f5cedf6233fc4f8..0eaa0bd97f9193d582bf47b55235b459d523d884 100644
--- a/chrome/browser/cocoa/download_request_dialog_delegate_mac.mm
+++ b/chrome/browser/cocoa/download_request_dialog_delegate_mac.mm
@@ -30,9 +30,9 @@
}
return self;
}
-- (void) alertDidEnd:(NSAlert *)alert
- returnCode:(int)returnCode
- contextInfo:(void *)contextInfo {
+- (void)alertDidEnd:(NSAlert *)alert
+ returnCode:(int)returnCode
+ contextInfo:(void *)contextInfo {
target_->SheetDidEnd(returnCode);
}
@end
@@ -82,11 +82,11 @@ void DownloadRequestDialogDelegateMac::CloseWindow() {
void DownloadRequestDialogDelegateMac::DeleteDelegate() {
if (is_sheet_open()) {
// Close sheet if it's still open.
- [NSApp endSheet:[(NSAlert*)sheet() window]]; // class SheetDidEnd().
+ [NSApp endSheet:[(NSAlert*)sheet() window]]; // calls SheetDidEnd().
DCHECK(responded_);
}
if (!responded_) {
- // Happens if the sheet was never visible
+ // Happens if the sheet was never visible.
responded_ = true;
DoCancel();
}
« no previous file with comments | « chrome/browser/cocoa/constrained_window_mac.mm ('k') | chrome/browser/login_prompt_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698