Issue 164391: Implement http auth login dialog for OS X.

Issue 164391: Implement http auth login dialog for OS X. (Closed)

Created:
11 years, 4 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement http auth login dialog for OS X. The login sheet looks very bare-bones…but that's probably ok for now. BUG=12043 TEST=Go to a page that uses http auth, e.g. http://www.pagetutor.com/keeper/mystash/secretstuff.html . A sheet should come up that asks for login and password. Escape should cancel the sheet, return should confirm it. The sheet should be per-tab, e.g. tab switching while the sheet is open should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23276

Patch Set 1 #

Patch Set 2 : correctly hide sheet #

Patch Set 3 : Fix gcc compilation issue #

Patch Set 4 : merge tot #

Patch Set 5 : re-disable nonfuntional test #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+882 lines, -47 lines)			Patch
A	chrome/app/nibs/HttpAuthLoginSheet.xib	View		1 chunk	+515 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/constrained_window_mac.h	View		1 chunk	+16 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/constrained_window_mac.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/download_request_dialog_delegate_mac.mm	View		2 chunks	+5 lines, -5 lines	0 comments	Download
A	chrome/browser/login_prompt_mac.h	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/browser/login_prompt_mac.mm	View	1	1 chunk	+308 lines, -0 lines	0 comments	Download
M	chrome/browser/login_prompt_uitest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3 4	4 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.cc	View	1 2 3	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

By the way: I copied login_prompt_mac.mm from login_prompt_gtk.cc and modified the UI bits. I did ...

11 years, 4 months ago (2009-08-12 09:18:58 UTC) #2

Avi (use Gerrit)

Mac side LGTM; I can't say much about the login mechanisms.

11 years, 4 months ago (2009-08-12 14:49:20 UTC) #3

Elliot Glaysher

11 years, 4 months ago (2009-08-12 16:33:18 UTC) #4

On 2009/08/12 14:49:20, Avi wrote:
> Mac side LGTM; I can't say much about the login mechanisms.

My objc is rusty, but login side LGTM.

Expand Messages | Collapse Messages