Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 16439015: cc: Fix use of uninitialized tiles. (Closed)

Created:
7 years, 6 months ago by reveman
Modified:
7 years, 6 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

cc: Fix use of uninitialized tiles. TileVersion::forced_upload_ needs to be reset before a tile is re-initialized or it will incorrectly be considered ready to draw before rasterization even starts. BUG=246642 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204610

Patch Set 1 #

Patch Set 2 : set force_upload_ to false in OnRasterTaskCompleted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M cc/resources/tile_manager.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reveman
7 years, 6 months ago (2013-06-06 04:41:44 UTC) #1
vmpstr
lgtm
7 years, 6 months ago (2013-06-06 15:44:27 UTC) #2
vmpstr
Can you actually reset it when the raster is completed as well? What I mean ...
7 years, 6 months ago (2013-06-06 15:45:51 UTC) #3
reveman
On 2013/06/06 15:45:51, vmpstr wrote: > Can you actually reset it when the raster is ...
7 years, 6 months ago (2013-06-06 15:58:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/16439015/5001
7 years, 6 months ago (2013-06-06 15:58:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/16439015/5001
7 years, 6 months ago (2013-06-06 21:26:47 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 21:42:53 UTC) #7
Message was sent while issue was closed.
Change committed as 204610

Powered by Google App Engine
This is Rietveld 408576698