Issue 164390: Merge 22314 - Use alternate icon for Chrome shortcuts if specified in master ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164390: Merge 22314 - Use alternate icon for Chrome shortcuts if specified in master ... (Closed)

Created:
11 years, 4 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
kuchhal

CC:
chromium-reviews_googlegroups.com, kuchhal, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 22314 - Use alternate icon for Chrome shortcuts if specified in master preferences. This change depends on change 159539 that is currently under review and a new chrome2.ico that is yet to be added to the repository. BUG=12701 TEST=Specify an alternate icon in installerdata file and make sure that icon is used for shortcuts and it not changed later by updates. Review URL: http://codereview.chromium.org/159618 TBR=kuchhal@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23180

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -52 lines)			Patch
MM	chrome/app/chrome_exe.rc	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	chrome/browser/first_run_win.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download
MM	chrome/installer/setup/install.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
MM	chrome/installer/setup/install.cc	View	3 chunks	+17 lines, -2 lines	0 comments	Download
MM	chrome/installer/setup/setup_main.cc	View	3 chunks	+4 lines, -18 lines	0 comments	Download
MM	chrome/installer/util/master_preferences.h	View	3 chunks	+6 lines, -2 lines	0 comments	Download
MM	chrome/installer/util/master_preferences.cc	View	3 chunks	+18 lines, -25 lines	0 comments	Download
MM	chrome/installer/util/shell_util.cc	View	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages