allow the caller to specified raster-surface rowbytes

allow the caller to specified raster-surface rowbytes.
along the way, simplify how we copy the surface's bitmap

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643873002

Committed: https://skia.googlesource.com/skia/+/9cd016e9b63f3827580d5b19a187dbf26b8e1436

[reed1, 2016-01-28 05:00:57]

Description was changed from

==========
allow the caller to specified raster-surface rowbytes

BUG=skia:
==========

to

==========
allow the caller to specified raster-surface rowbytes

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-28 05:01:38]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 05:02:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643873002/1

[commit-bot: I haz the power, 2016-01-28 05:12:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 05:12:54]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-01-29 02:01:01]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-01-29 02:01:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643873002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643873002/60001

[commit-bot: I haz the power, 2016-01-29 02:01:13]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-01-29 08:01 UTC

[reed1, 2016-01-29 02:02:11]

Description was changed from

==========
allow the caller to specified raster-surface rowbytes

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
allow the caller to specified raster-surface rowbytes.
along the way, simplify how we copy the surface's bitmap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-29 02:57:30]

reed@google.com changed reviewers:
+ bsalomon@google.com, lsalzman@mozilla.com

[reed1, 2016-01-29 02:57:31]

ptal

[reed1, 2016-01-29 02:57:35]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 02:57:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643873002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643873002/80001

[commit-bot: I haz the power, 2016-01-29 03:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 03:18:57]

Dry run: This issue passed the CQ dry run.

[lsalzman1, 2016-01-29 04:40:40]

lgtm

This will allow us to clear up at least one of our inter-op issues with Cairo.

[bsalomon, 2016-01-29 13:59:25]

lgtm, two q's inline

https://codereview.chromium.org/1643873002/diff/80001/src/image/SkSurface_Ras...
File src/image/SkSurface_Raster.cpp (right):

https://codereview.chromium.org/1643873002/diff/80001/src/image/SkSurface_Ras...
src/image/SkSurface_Raster.cpp:193: SkAutoTUnref<SkPixelRef>
pr(SkMallocPixelRef::NewZeroed(info, rowBytes, nullptr));
Does this validate the rowBytes (fail if rowbytes too small)?

https://codereview.chromium.org/1643873002/diff/80001/tests/SurfaceTest.cpp
File tests/SurfaceTest.cpp (right):

https://codereview.chromium.org/1643873002/diff/80001/tests/SurfaceTest.cpp#n...
tests/SurfaceTest.cpp:686: REPORTER_ASSERT(reporter, im_rowbytes2 ==
im_rowbytes);
Should we doc this behavior with the SkSurface factory method? (images snapped
from a raster surface have the same rowbytes as the surface)?

[bsalomon, 2016-01-29 13:59:25]

lgtm, two q's inline

https://codereview.chromium.org/1643873002/diff/80001/src/image/SkSurface_Ras...
File src/image/SkSurface_Raster.cpp (right):

https://codereview.chromium.org/1643873002/diff/80001/src/image/SkSurface_Ras...
src/image/SkSurface_Raster.cpp:193: SkAutoTUnref<SkPixelRef>
pr(SkMallocPixelRef::NewZeroed(info, rowBytes, nullptr));
Does this validate the rowBytes (fail if rowbytes too small)?

https://codereview.chromium.org/1643873002/diff/80001/tests/SurfaceTest.cpp
File tests/SurfaceTest.cpp (right):

https://codereview.chromium.org/1643873002/diff/80001/tests/SurfaceTest.cpp#n...
tests/SurfaceTest.cpp:686: REPORTER_ASSERT(reporter, im_rowbytes2 ==
im_rowbytes);
Should we doc this behavior with the SkSurface factory method? (images snapped
from a raster surface have the same rowbytes as the surface)?

[reed1, 2016-01-30 00:52:48]

https://codereview.chromium.org/1643873002/diff/80001/src/image/SkSurface_Ras...
File src/image/SkSurface_Raster.cpp (right):

https://codereview.chromium.org/1643873002/diff/80001/src/image/SkSurface_Ras...
src/image/SkSurface_Raster.cpp:193: SkAutoTUnref<SkPixelRef>
pr(SkMallocPixelRef::NewZeroed(info, rowBytes, nullptr));
On 2016/01/29 13:59:25, bsalomon wrote:
> Does this validate the rowBytes (fail if rowbytes too small)?

Indeed. the unittest tests for that, and passes because that behavior is built
into mallocpixelref.

https://codereview.chromium.org/1643873002/diff/80001/tests/SurfaceTest.cpp
File tests/SurfaceTest.cpp (right):

https://codereview.chromium.org/1643873002/diff/80001/tests/SurfaceTest.cpp#n...
tests/SurfaceTest.cpp:686: REPORTER_ASSERT(reporter, im_rowbytes2 ==
im_rowbytes);
On 2016/01/29 13:59:25, bsalomon wrote:
> Should we doc this behavior with the SkSurface factory method? (images snapped
> from a raster surface have the same rowbytes as the surface)?

Done.

[reed1, 2016-01-30 00:53:04]

The CQ bit was checked by reed@google.com

[reed1, 2016-01-30 00:53:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
lsalzman@mozilla.com, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1643873002/#ps100001
(title: "update dox for snapped image rowbytes")

[commit-bot: I haz the power, 2016-01-30 00:53:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643873002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643873002/100001

[commit-bot: I haz the power, 2016-01-30 18:01:09]

Description was changed from

==========
allow the caller to specified raster-surface rowbytes.
along the way, simplify how we copy the surface's bitmap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
allow the caller to specified raster-surface rowbytes.
along the way, simplify how we copy the surface's bitmap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9cd016e9b63f3827580d5b19a187dbf26b8e1436
==========

[commit-bot: I haz the power, 2016-01-30 18:01:09]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/9cd016e9b63f3827580d5b19a187dbf26b8e1436