Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 164386: Merge 23081 - With the recent NNTP changes, we change the way themes work th... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 23081 - With the recent NNTP changes, we change the way themes work they're now closer to NTP1 theming ntp_section_* is used to control the display of the light blue sections, and we've added ntp_header that controls the dark blue hover color, ntp_header falls back to ntp_section if provided. Also fix a minor bug where the default theme was saving theme data we were generating colors before saving the provided colors. BUG=18720, 18722 TEST=Install a theme and verify that the recently closed section is themed correctly. Review URL: http://codereview.chromium.org/165192 TBR=glen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -32 lines) Patch
MM chrome/browser/browser_theme_provider.h View 3 chunks +3 lines, -0 lines 0 comments Download
MM chrome/browser/browser_theme_provider.cc View 7 chunks +24 lines, -6 lines 0 comments Download
MM chrome/browser/dom_ui/dom_ui_theme_source.cc View 2 chunks +23 lines, -10 lines 0 comments Download
MM chrome/browser/resources/new_new_tab.css View 2 chunks +1 line, -7 lines 0 comments Download
MM chrome/browser/resources/new_tab_theme.css View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 4 months ago (2009-08-12 03:59:10 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698