Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 1643833002: Devtools: Fix enter to accept autocomplete in styles pane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 2711 matching lines...) Expand 10 before | Expand all | Expand 10 after
2722 case "Up": 2722 case "Up":
2723 case "Down": 2723 case "Down":
2724 case "PageUp": 2724 case "PageUp":
2725 case "PageDown": 2725 case "PageDown":
2726 if (this._handleNameOrValueUpDown(event)) { 2726 if (this._handleNameOrValueUpDown(event)) {
2727 event.preventDefault(); 2727 event.preventDefault();
2728 return; 2728 return;
2729 } 2729 }
2730 break; 2730 break;
2731 case "Enter": 2731 case "Enter":
2732 if (this.autoCompleteElement && !this.autoCompleteElement.textConten t.length) { 2732 if (this.autoCompleteElement && this.autoCompleteElement.textContent .length) {
pfeldman 2016/01/28 00:10:16 This change is somewhat subtle. It might interfere
samli 2016/01/28 00:22:50 Done.
2733 this.tabKeyPressed(); 2733 this.tabKeyPressed();
2734 return; 2734 return;
2735 } 2735 }
2736 break; 2736 break;
2737 } 2737 }
2738 2738
2739 WebInspector.TextPrompt.prototype.onKeyDown.call(this, event); 2739 WebInspector.TextPrompt.prototype.onKeyDown.call(this, event);
2740 }, 2740 },
2741 2741
2742 /** 2742 /**
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
2966 WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, onNodeCha nged); 2966 WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, onNodeCha nged);
2967 onNodeChanged(); 2967 onNodeChanged();
2968 return button; 2968 return button;
2969 2969
2970 function onNodeChanged() 2970 function onNodeChanged()
2971 { 2971 {
2972 var node = WebInspector.context.flavor(WebInspector.DOMNode); 2972 var node = WebInspector.context.flavor(WebInspector.DOMNode);
2973 button.setEnabled(!!node); 2973 button.setEnabled(!!node);
2974 } 2974 }
2975 } 2975 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698