Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1643833002: Devtools: Fix enter to accept autocomplete in styles pane (Closed)

Created:
4 years, 11 months ago by samli
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Fix enter to accept autocomplete in styles pane This bug was exposed in https://codereview.chromium.org/1611783002 BUG=581909 Committed: https://crrev.com/4ffcc549c7235722b717dac4b5b41c3a701cfefb Cr-Commit-Position: refs/heads/master@{#371976}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
samli
4 years, 11 months ago (2016-01-28 00:05:48 UTC) #4
pfeldman
https://codereview.chromium.org/1643833002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/1643833002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode2732 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:2732: if (this.autoCompleteElement && this.autoCompleteElement.textContent.length) { This change is somewhat ...
4 years, 11 months ago (2016-01-28 00:10:16 UTC) #5
samli
https://codereview.chromium.org/1643833002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/1643833002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode2732 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:2732: if (this.autoCompleteElement && this.autoCompleteElement.textContent.length) { On 2016/01/28 at 00:10:16, ...
4 years, 11 months ago (2016-01-28 00:22:50 UTC) #6
pfeldman
lgtm
4 years, 11 months ago (2016-01-28 01:11:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643833002/20001
4 years, 11 months ago (2016-01-28 01:29:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-28 02:55:23 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:57:17 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4ffcc549c7235722b717dac4b5b41c3a701cfefb
Cr-Commit-Position: refs/heads/master@{#371976}

Powered by Google App Engine
This is Rietveld 408576698