Renames the NavigationEntry::display_url() to virtual_url()....

Renames the NavigationEntry::display_url() to virtual_url().

BUG=6970
(http://crbug.com/6970)
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23357

[tfarina (gmail-do not use), 2009-08-12 03:36:28]

Please review this to me!

Thanks!

[tony, 2009-08-13 00:44:45]

http://codereview.chromium.org/164383/diff/1/4
File chrome/browser/memory_details.cc (right):

http://codereview.chromium.org/164383/diff/1/4#newcode235
Line 235: // We need to check the pending entry as well as the display_url to
display_url -> virtual_url

http://codereview.chromium.org/164383/diff/1/6
File chrome/browser/tab_contents/navigation_entry.h (left):

http://codereview.chromium.org/164383/diff/1/6#oldcode401
Line 401: // displayed. When the URL, display URL, or title is set, this should
be
display URL -> virtual URL

http://codereview.chromium.org/164383/diff/1/6
File chrome/browser/tab_contents/navigation_entry.h (right):

http://codereview.chromium.org/164383/diff/1/6#newcode240
Line 240: // The display URL, when nonempty, will override the actual URL of the
page
virtual

http://codereview.chromium.org/164383/diff/1/7
File chrome/browser/tab_contents/navigation_entry_unittest.cc (right):

http://codereview.chromium.org/164383/diff/1/7#newcode47
Line 47: // Start with no display_url (even if a url is set)
virtual

http://codereview.chromium.org/164383/diff/1/7#newcode55
Line 55: // Setting URL affects display_url and GetTitleForDisplay
virtual_url

http://codereview.chromium.org/164383/diff/1/7#newcode66
Line 66: // Setting display_url doesn't affect URL
virtual

http://codereview.chromium.org/164383/diff/1/7#newcode72
Line 72: // Having a title set in constructor overrides display URL
virtual

http://codereview.chromium.org/164383/diff/1/11
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/164383/diff/1/11#newcode1353
Line 1353: const NavigationController::LoadCommittedDetails& details,
It would be nice to update this param too.

http://codereview.chromium.org/164383/diff/1/11#newcode1363
Line 1363: // Hack on the "display" URL so that it will appear in history. For
some
This comment should be updated.

[tfarina (gmail-do not use), 2009-08-13 01:37:32]

http://codereview.chromium.org/164383/diff/1/4
File chrome/browser/memory_details.cc (right):

http://codereview.chromium.org/164383/diff/1/4#newcode235
Line 235: // We need to check the pending entry as well as the display_url to
On 2009/08/13 00:44:45, tony wrote:
> display_url -> virtual_url

Done.

http://codereview.chromium.org/164383/diff/1/6
File chrome/browser/tab_contents/navigation_entry.h (right):

http://codereview.chromium.org/164383/diff/1/6#newcode240
Line 240: // The display URL, when nonempty, will override the actual URL of the
page
On 2009/08/13 00:44:45, tony wrote:
> virtual

Done.

http://codereview.chromium.org/164383/diff/1/7
File chrome/browser/tab_contents/navigation_entry_unittest.cc (right):

http://codereview.chromium.org/164383/diff/1/7#newcode47
Line 47: // Start with no display_url (even if a url is set)
On 2009/08/13 00:44:45, tony wrote:
> virtual

Done.

http://codereview.chromium.org/164383/diff/1/7#newcode55
Line 55: // Setting URL affects display_url and GetTitleForDisplay
On 2009/08/13 00:44:45, tony wrote:
> virtual_url

Done.

http://codereview.chromium.org/164383/diff/1/7#newcode66
Line 66: // Setting display_url doesn't affect URL
On 2009/08/13 00:44:45, tony wrote:
> virtual

Done.

http://codereview.chromium.org/164383/diff/1/7#newcode72
Line 72: // Having a title set in constructor overrides display URL
On 2009/08/13 00:44:45, tony wrote:
> virtual

Done.

http://codereview.chromium.org/164383/diff/1/11
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/164383/diff/1/11#newcode1353
Line 1353: const NavigationController::LoadCommittedDetails& details,
On 2009/08/13 00:44:45, tony wrote:
> It would be nice to update this param too.

Done.

http://codereview.chromium.org/164383/diff/1/11#newcode1363
Line 1363: // Hack on the "display" URL so that it will appear in history. For
some
On 2009/08/13 00:44:45, tony wrote:
> This comment should be updated.

Done.

[tony, 2009-08-13 17:45:38]

LGTM, do you want me to commit it for you?

http://codereview.chromium.org/164383/diff/22/1024
File chrome/browser/tab_contents/navigation_entry.cc (right):

http://codereview.chromium.org/164383/diff/22/1024#newcode77
Line 77: // Use the display URL first if any, and fall back on using the real
URL.
virtual

http://codereview.chromium.org/164383/diff/22/1022
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/164383/diff/22/1022#newcode1361
Line 1361: // Hack on the "display" URL so that it will appear in history. For
some
virtual

[tfarina (gmail-do not use), 2009-08-13 18:03:50]

Yeah, please!

Thanks for the review!

http://codereview.chromium.org/164383/diff/22/1024
File chrome/browser/tab_contents/navigation_entry.cc (right):

http://codereview.chromium.org/164383/diff/22/1024#newcode77
Line 77: // Use the display URL first if any, and fall back on using the real
URL.
On 2009/08/13 17:45:38, tony wrote:
> virtual

Done.

http://codereview.chromium.org/164383/diff/22/1022
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/164383/diff/22/1022#newcode1361
Line 1361: // Hack on the "display" URL so that it will appear in history. For
some
On 2009/08/13 17:45:38, tony wrote:
> virtual

Done.

[tony, 2009-08-13 18:29:10]

Did you try compiling this?  I get compile errors in navigation_controller.cc. 
Also, how did you create the diff? tab_contents.cc is in the patch file twice.

[tfarina (gmail-do not use), 2009-08-13 19:54:03]

On 2009/08/13 18:29:10, tony wrote:
> Did you try compiling this?  I get compile errors in navigation_controller.cc.

> Also, how did you create the diff? tab_contents.cc is in the patch file twice.
Fixed the navigation_controller.cc. And removed the duplicated entry of
tab_contents.cc

[tony, 2009-08-13 20:46:13]

Landed in r23357