Issue 1643823003: bug?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1643823003: bug?

Created:
4 years, 10 months ago by zino

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

bug? BUG=

Patch Set 1 #

Total comments: 2

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	A	third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test.js	View		1 chunk	+17 lines, -0 lines	1 comment	Download
	A	third_party/WebKit/LayoutTests/http/tests/serviceworker/test.html	View		1 chunk	+31 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nhiroki

4 years, 10 months ago (2016-02-08 04:54:02 UTC) #3

https://codereview.chromium.org/1643823003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test.js
(right):

https://codereview.chromium.org/1643823003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test.js:16:
e.waitUntil(receive_message());
A promise returned by receive_message() is never settled because iframe cannot
finish and postMessage() is not called.

https://codereview.chromium.org/1643823003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/serviceworker/test.html (right):

https://codereview.chromium.org/1643823003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/test.html:22: return
with_iframe(scope);
This promise is never settled (or settled when the activate event is timed out)
because the browser process cannot dispatch the fetch event before the
installed/activating worker becomes activated.

See my comment for details:
https://codereview.chromium.org/1604893002/#msg16

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages