Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1643823002: Revert of Fix flaky remoting webapp javascript unittest. (Closed)

Created:
4 years, 10 months ago by Garrett Casto
Modified:
4 years, 10 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix flaky remoting webapp javascript unittest. (patchset #1 id:1 of https://codereview.chromium.org/1633273002/ ) Reason for revert: This is still quite flaky on Linux. It has failed the 3 times in a row now. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Original issue's description: > Fix flaky remoting webapp javascript unittest. > > After forcing tests to fail after a 10 seconds timeout, turns out the > spy promise tests are the culprit. > I have removed them from our tests as they are originally intended to > test XHR's and we now have a better API for that. > > BUG=504204 > > Committed: https://crrev.com/aeb109ffd9b79927edb6a75f8cef7e72792fb356 > Cr-Commit-Position: refs/heads/master@{#371658} TBR=jamiewalch@chromium.org,kelvinp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504204 Committed: https://crrev.com/8c790b2b91fc0b98c6f984c7454756a6602b325d Cr-Commit-Position: refs/heads/master@{#371934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -8 lines) Patch
M chrome/test/remoting/webapp_javascript_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/webapp/base/js/dns_blackhole_checker_unittest.js View 7 chunks +7 lines, -7 lines 0 comments Download
M remoting/webapp/files.gni View 1 chunk +3 lines, -0 lines 0 comments Download
A remoting/webapp/unittests/spy_promise.js View 1 chunk +294 lines, -0 lines 0 comments Download
A remoting/webapp/unittests/spy_promise_unittest.js View 1 chunk +253 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Garrett Casto
Created Revert of Fix flaky remoting webapp javascript unittest.
4 years, 10 months ago (2016-01-28 00:03:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643823002/1
4 years, 10 months ago (2016-01-28 00:07:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 00:27:05 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 00:35:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c790b2b91fc0b98c6f984c7454756a6602b325d
Cr-Commit-Position: refs/heads/master@{#371934}

Powered by Google App Engine
This is Rietveld 408576698