Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1643813002: [Blimp Net] Use checkpoitner (Closed)

Created:
4 years, 11 months ago by haibinlu
Modified:
4 years, 11 months ago
Reviewers:
Kevin M
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blimp Net] Use checkpoitner Otherwise, ACK buffer will buildup in BlimpMessageOutputBuffer. Committed: https://crrev.com/fd908d2de50a4e6a77661e5ade749e008c29ac27 Cr-Commit-Position: refs/heads/master@{#371966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M blimp/net/browser_connection_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
haibinlu
4 years, 11 months ago (2016-01-28 00:03:47 UTC) #2
Kevin M
lgtm
4 years, 11 months ago (2016-01-28 00:49:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643813002/1
4 years, 11 months ago (2016-01-28 01:06:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 02:15:07 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:17:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd908d2de50a4e6a77661e5ade749e008c29ac27
Cr-Commit-Position: refs/heads/master@{#371966}

Powered by Google App Engine
This is Rietveld 408576698