Revert of GN: Use special toolchain for nacl64.exe, force is_component_build off

Revert of GN: Use special toolchain for nacl64.exe, force is_component_build off (patchset #2 id:20001 of https://codereview.chromium.org/1580723006/ )

Reason for revert:
We are seeing errors on Win x64 fre/chk GN build bots and this is the most likely cause.  Reverting.

Original issue's description:
> GN: Use special toolchain for nacl64.exe, force is_component_build off
>
> The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
> compatible with component-style builds.  Build nacl64.exe in a special
> variant of the x64 toolchain, wherein is_component_build is always false.
>
> BUG=512869
> R=bradnelson@chromium.org, dpranke@chromium.org
>
> Committed: https://crrev.com/8fdf65ae2d38dc0c7bb9ff8f36b4c1f48055844a
> Cr-Commit-Position: refs/heads/master@{#372217}

TBR=bradnelson@chromium.org,dpranke@chromium.org,mcgrathr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=512869
Committed: https://crrev.com/238933500209bb447b1e35e7ba0d7cab61ac89c1
Cr-Commit-Position: refs/heads/master@{#372229}

[joedow, 2016-01-29 00:48:00]

Created Revert of GN: Use special toolchain for nacl64.exe, force
is_component_build off

[commit-bot: I haz the power, 2016-01-29 00:49:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643803006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643803006/1

[commit-bot: I haz the power, 2016-01-29 00:51:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-29 00:53:30]

Description was changed from

==========
Revert of GN: Use special toolchain for nacl64.exe, force is_component_build off
(patchset #2 id:20001 of https://codereview.chromium.org/1580723006/ )

Reason for revert:
We are seeing errors on Win x64 fre/chk GN build bots and this is the most
likely cause.  Reverting.

Original issue's description:
> GN: Use special toolchain for nacl64.exe, force is_component_build off
> 
> The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
> compatible with component-style builds.  Build nacl64.exe in a special
> variant of the x64 toolchain, wherein is_component_build is always false.
> 
> BUG=512869
> R=bradnelson@chromium.org, dpranke@chromium.org
> 
> Committed: https://crrev.com/8fdf65ae2d38dc0c7bb9ff8f36b4c1f48055844a
> Cr-Commit-Position: refs/heads/master@{#372217}

TBR=bradnelson@chromium.org,dpranke@chromium.org,mcgrathr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=512869
==========

to

==========
Revert of GN: Use special toolchain for nacl64.exe, force is_component_build off
(patchset #2 id:20001 of https://codereview.chromium.org/1580723006/ )

Reason for revert:
We are seeing errors on Win x64 fre/chk GN build bots and this is the most
likely cause.  Reverting.

Original issue's description:
> GN: Use special toolchain for nacl64.exe, force is_component_build off
>
> The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
> compatible with component-style builds.  Build nacl64.exe in a special
> variant of the x64 toolchain, wherein is_component_build is always false.
>
> BUG=512869
> R=bradnelson@chromium.org, dpranke@chromium.org
>
> Committed: https://crrev.com/8fdf65ae2d38dc0c7bb9ff8f36b4c1f48055844a
> Cr-Commit-Position: refs/heads/master@{#372217}

TBR=bradnelson@chromium.org,dpranke@chromium.org,mcgrathr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=512869

Committed: https://crrev.com/238933500209bb447b1e35e7ba0d7cab61ac89c1
Cr-Commit-Position: refs/heads/master@{#372229}
==========

[commit-bot: I haz the power, 2016-01-29 00:53:31]

Patchset 1 (id:??) landed as
https://crrev.com/238933500209bb447b1e35e7ba0d7cab61ac89c1
Cr-Commit-Position: refs/heads/master@{#372229}

[Roland McGrath, 2016-01-29 01:03:39]

lgtm

[Dirk Pranke, 2016-01-29 01:04:12]

lgtm also.

link to logs for the failure?

[joedow, 2016-01-29 01:57:46]

On 2016/01/29 01:04:12, Dirk Pranke wrote:
> lgtm also.
> 
> link to logs for the failure?

Link to build failure:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/10480

Error log:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/1048...

Error:
E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64
"--args=is_debug=false is_component_build=false use_goma=true
goma_dir=\"E:\b\build\goma\" symbol_level=1" --check
  -> returned 1
ERROR at //build/toolchain/win/BUILD.gn:242:14: Assignment had no effect.
  clang_cl = "clang-cl.exe"
             ^-------------
You set the variable "clang_cl" here and it was unused before it went
out of scope.