src/object-observe.js - Issue 16438010: Remove redudant deleted_count argument from EnqueueSpliceRecord

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/object-observe.js

Issue 16438010: Remove redudant deleted_count argument from EnqueueSpliceRecord (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: cr changes Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/object-observe.js

diff --git a/src/object-observe.js b/src/object-observe.js

index 5ca70bcff565c8daf8fc15d8343aee3bbd0b59c8..ada7919d6dd215f6d49470f30dca230d14f02d83 100644

--- a/src/object-observe.js

+++ b/src/object-observe.js

@@ -294,7 +294,7 @@ function EndPerformSplice(array) {

EndPerformChange(objectInfo, 'splice');

}

-function EnqueueSpliceRecord(array, index, removed, deleteCount, addedCount) {

+function EnqueueSpliceRecord(array, index, removed, addedCount) {

var objectInfo = objectInfoMap.get(array);

if (IS_UNDEFINED(objectInfo) || objectInfo.changeObservers.length === 0)

return;

@@ -307,7 +307,6 @@ function EnqueueSpliceRecord(array, index, removed, deleteCount, addedCount) {

addedCount: addedCount

};

- changeRecord.removed.length = deleteCount;

ObjectFreeze(changeRecord);

ObjectFreeze(changeRecord.removed);

EnqueueChangeRecord(changeRecord, objectInfo.changeObservers);

« no previous file with comments | « src/array.js ('k') | src/objects.cc » ('j') | no next file with comments »