Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 16438010: Remove redudant deleted_count argument from EnqueueSpliceRecord (Closed)

Created:
7 years, 6 months ago by rafaelw
Modified:
7 years, 6 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Remove redudant deleted_count argument from EnqueueSpliceRecord R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14989

Patch Set 1 #

Total comments: 4

Patch Set 2 : cr changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M src/array.js View 5 chunks +4 lines, -5 lines 0 comments Download
M src/object-observe.js View 2 chunks +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 3 chunks +8 lines, -10 lines 0 comments Download
M src/v8natives.js View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rafaelw
7 years, 6 months ago (2013-06-05 17:04:31 UTC) #1
adamk
https://codereview.chromium.org/16438010/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/16438010/diff/1/src/objects.cc#newcode10970 src/objects.cc:10970: SetProperty(deleted, isolate->factory()->length_string(), This can go inside the if (delete_count) ...
7 years, 6 months ago (2013-06-05 17:22:03 UTC) #2
rossberg
LGTM with nits https://codereview.chromium.org/16438010/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/16438010/diff/1/src/objects.cc#newcode10963 src/objects.cc:10963: if (delete_count) { Nit: can we ...
7 years, 6 months ago (2013-06-06 09:12:05 UTC) #3
rafaelw
done https://codereview.chromium.org/16438010/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/16438010/diff/1/src/objects.cc#newcode10963 src/objects.cc:10963: if (delete_count) { On 2013/06/06 09:12:05, rossberg wrote: ...
7 years, 6 months ago (2013-06-06 18:44:41 UTC) #4
adamk
7 years, 6 months ago (2013-06-06 19:15:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14989 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698