Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1643783002: Fix analyzer warnings for https://codereview.chromium.org/1642493002 (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index aa16b1888a2549216afc6f33ece7c3026a7c8159..f98c9dddeb50f705d60e54a7543b99c19ca0c804 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -918,15 +918,16 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
// Only call setRuntimeTypeInfo if JSArray requires the type parameter.
if (requiresRuntimeTypes) {
assert(parameters.length == 2);
+ closure.TypeVariableLocal typeParameter = parameters[1];
ir.Primitive typeArgument =
- irBuilder.buildTypeVariableAccess(parameters[1].typeVariable);
+ irBuilder.buildTypeVariableAccess(typeParameter.typeVariable);
ir.Primitive typeInformation = irBuilder.addPrimitive(
new ir.TypeExpression(ir.TypeExpressionKind.INSTANCE,
element.enclosingClass.thisType,
<ir.Primitive>[typeArgument]));
- Element helper = helpers.setRuntimeTypeInfo;
+ MethodElement helper = helpers.setRuntimeTypeInfo;
CallStructure callStructure = CallStructure.TWO_ARGS;
Selector selector = new Selector.call(helper.memberName, callStructure);
allocation = irBuilder.buildInvokeStatic(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698