Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1643753002: kill SkValue (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -620 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/effects.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkXfermode.h View 2 chunks +0 lines, -4 lines 0 comments Download
M include/effects/SkPixelXorXfermode.h View 1 chunk +0 lines, -2 lines 0 comments Download
D src/core/SkValue.h View 1 chunk +0 lines, -116 lines 0 comments Download
D src/core/SkValue.cpp View 1 chunk +0 lines, -185 lines 0 comments Download
D src/core/SkValueKeys.h View 1 chunk +0 lines, -20 lines 0 comments Download
M src/core/SkXfermode.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 3 chunks +1 line, -14 lines 0 comments Download
M src/effects/SkPixelXorXfermode.cpp View 4 chunks +3 lines, -12 lines 0 comments Download
D src/effects/SkToFromValue.h View 1 chunk +0 lines, -21 lines 0 comments Download
D src/effects/SkToFromValue.cpp View 1 chunk +0 lines, -121 lines 0 comments Download
D tests/ValueTest.cpp View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643753002/1
4 years, 10 months ago (2016-01-27 20:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643753002/1
4 years, 10 months ago (2016-01-27 21:03:09 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 21:08:36 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bbb6dc80fdfe6ff08cc1abb1a401bd958ced9602

Powered by Google App Engine
This is Rietveld 408576698