Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: components/filesystem/public/interfaces/file.mojom

Issue 1643733002: Revert of mojo filesystem: Simplify full file reading/writing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/filesystem/public/interfaces/directory.mojom ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(vtl): notes to self: 5 // TODO(vtl): notes to self:
6 // - file offsets, file positions, and file sizes are int64 (though positions 6 // - file offsets, file positions, and file sizes are int64 (though positions
7 // and sizes must always be non-negative) 7 // and sizes must always be non-negative)
8 // - buffer size parameters (for read/write) are uint32 8 // - buffer size parameters (for read/write) are uint32
9 9
10 module filesystem; 10 module filesystem;
11 11
12 import "components/filesystem/public/interfaces/types.mojom"; 12 import "components/filesystem/public/interfaces/types.mojom";
13 13
14 // TODO(vtl): Write comments. 14 // TODO(vtl): Write comments.
15 interface File { 15 interface File {
16 // Flushes/closes this file; no operations may be performed on this file after 16 // Flushes/closes this file; no operations may be performed on this file after
17 // this. Note that any error code is strictly informational -- the close may 17 // this. Note that any error code is strictly informational -- the close may
18 // not be retried. 18 // not be retried.
19 Close() => (FileError err); 19 Close() => (FileError err);
20 20
21 // Reads (at most) |num_bytes_to_read| from the location specified by 21 // Reads (at most) |num_bytes_to_read| from the location specified by
22 // |offset|/|whence|. On success, |bytes_read| is set to the data read. 22 // |offset|/|whence|. On success, |bytes_read| is set to the data read.
23 // TODO(vtl): Define/clarify behavior when less than |num_bytes_to_read| bytes 23 // TODO(vtl): Define/clarify behavior when less than |num_bytes_to_read| bytes
24 // are read. 24 // are read.
25 // TODO(vtl): Clarify when (for what values of |offset|/|whence|) this 25 // TODO(vtl): Clarify when (for what values of |offset|/|whence|) this
26 // modifies the file position. Or maybe there should be a flag? 26 // modifies the file position. Or maybe there should be a flag?
27 Read(uint32 num_bytes_to_read, int64 offset, Whence whence) 27 Read(uint32 num_bytes_to_read, int64 offset, Whence whence)
28 => (FileError error, array<uint8>? bytes_read); 28 => (FileError error, array<uint8>? bytes_read);
29 29
30 // Returns the entire contents of the file as an array of bytes. The mojo
31 // equivalent of base::ReadFileToString().
32 ReadEntireFile() => (FileError error, array<uint8>? bytes_read);
33
30 // Writes |bytes_to_write| to the location specified by |offset|/|whence|. 34 // Writes |bytes_to_write| to the location specified by |offset|/|whence|.
31 // TODO(vtl): Clarify behavior when |num_bytes_written| is less than the size 35 // TODO(vtl): Clarify behavior when |num_bytes_written| is less than the size
32 // of |bytes_to_write|. 36 // of |bytes_to_write|.
33 Write(array<uint8> bytes_to_write, int64 offset, Whence whence) 37 Write(array<uint8> bytes_to_write, int64 offset, Whence whence)
34 => (FileError error, uint32 num_bytes_written); 38 => (FileError error, uint32 num_bytes_written);
35 39
36 // Gets the current file position. On success, |position| is the current 40 // Gets the current file position. On success, |position| is the current
37 // offset (in bytes) from the beginning of the file). 41 // offset (in bytes) from the beginning of the file).
38 Tell() => (FileError error, int64 position); 42 Tell() => (FileError error, int64 position);
39 43
(...skipping 18 matching lines...) Expand all
58 // I.e., the access mode, etc. (as specified to |Directory::OpenFile()| by the 62 // I.e., the access mode, etc. (as specified to |Directory::OpenFile()| by the
59 // |open_flags| argument) as well as file position. 63 // |open_flags| argument) as well as file position.
60 Dup(File& file) => (FileError error); 64 Dup(File& file) => (FileError error);
61 65
62 // Syncs data to disk. 66 // Syncs data to disk.
63 Flush() => (FileError error); 67 Flush() => (FileError error);
64 68
65 // Returns a handle to the file for raw access. 69 // Returns a handle to the file for raw access.
66 AsHandle() => (FileError error, handle file_handle); 70 AsHandle() => (FileError error, handle file_handle);
67 }; 71 };
OLDNEW
« no previous file with comments | « components/filesystem/public/interfaces/directory.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698