Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2701)

Unified Diff: chrome/browser/resources/md_history/history_card_manager.html

Issue 1643693003: MD History: Implement search functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded
Patch Set: Fix commenting. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/history_card_manager.html
diff --git a/chrome/browser/resources/md_history/history_card_manager.html b/chrome/browser/resources/md_history/history_card_manager.html
index 7108a87abc6593da7befccbd5ac3cc9501c978e2..a623ed0fc4dd1999ae9d0798b175f290013e591b 100644
--- a/chrome/browser/resources/md_history/history_card_manager.html
+++ b/chrome/browser/resources/md_history/history_card_manager.html
@@ -17,6 +17,10 @@
display: block;
}
+ [hidden] {
+ display: none !important;
+ }
+
#overflow-menu {
@apply(--shadow-elevation-2dp);
border-radius: 2px;
@@ -40,11 +44,27 @@
paper-item:hover {
background: #eaeaea;
}
+
+ #no-results {
+ flex: 1;
+ align-items: center;
+ color: #b4b4b4;
+ display: flex;
calamity 2016/02/05 02:30:10 Should be able to remove this.
hsampson 2016/02/08 04:40:23 It looks like it but if I try removing any of the
+ font-size: 123.1%;
calamity 2016/02/05 02:30:10 This is an interesting font size...
hsampson 2016/02/08 04:40:23 Yea just copied it from md_downloads as there are
+ font-weight: 500;
+ justify-content: center;
+ }
</style>
+ <div id="no-results"
+ hidden$="{{resultsAvailable_(historyDataByDay_.length, loading_)}}">
+ {{noResultsMessage_}}
tsergeant 2016/02/04 02:28:49 Can this be a computed function instead of a prope
hsampson 2016/02/08 04:40:23 Done.
tsergeant 2016/02/08 22:59:01 Meep, what I meant here was to create a function l
hsampson 2016/02/09 02:17:51 Done.
tsergeant 2016/02/09 04:28:53 This still isn't quite what I intended, but it doe
+ </div>
<iron-list items="{{historyDataByDay_}}" as="historyDay" id="infinite-list"
- on-scroll="scrollHandler_">
+ on-scroll="scrollHandler_"
+ hidden$="{{!resultsAvailable_(historyDataByDay_.length, loading_)}}">
<template>
<history-card history-date="{{historyDay.date}}"
+ search-term="[[searchTerm]]"
history-items="{{historyDay.historyItems}}">
</history-card>
</template>

Powered by Google App Engine
This is Rietveld 408576698