Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: chrome/browser/resources/md_history/history_card.html

Issue 1643693003: MD History: Implement search functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded
Patch Set: Fix commenting. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/history_card.html
diff --git a/chrome/browser/resources/md_history/history_card.html b/chrome/browser/resources/md_history/history_card.html
index 706da7fc406471b9dac69d49eaee53b9cc589304..15307cc515c61f8ee82dfe4b502f2acb4cc5faac 100644
--- a/chrome/browser/resources/md_history/history_card.html
+++ b/chrome/browser/resources/md_history/history_card.html
@@ -12,6 +12,10 @@
padding: 0 24px 20px;
}
+ :host([hidden]) {
+ display: none !important;
+ }
+
#main-container {
@apply(--shadow-elevation-2dp);
background: #fff;
@@ -45,7 +49,9 @@
</style>
<div id="main-container">
- <div id="date-accessed">[[historyDate]]</div>
+ <div id="date-accessed">
+ {{searchResultTitle_(historyItems.length, searchTerm, historyDate)}}
tsergeant 2016/02/04 02:28:49 Can you rename searchResultTitle to cardTitle or s
hsampson 2016/02/08 04:40:22 Done.
+ </div>
<div id="history-item-list">
<template is="dom-repeat" items="[[historyItems]]"
tsergeant 2016/02/04 02:28:49 Make sure this is rebased correctly, so that bug d
hsampson 2016/02/08 04:40:22 Done.
as="historyItem">
@@ -55,9 +61,10 @@
website-url_="[[historyItem.url]]"
starred="[[historyItem.starred]]"
selected="{{historyItem.selected}}"
- timestamp_="[[historyItem.time]]">
+ timestamp_="[[historyItem.time]]"
+ search-term="[[searchTerm]]">
</history-item>
- <template is="dom-if" if="[[needsTimeGap_(index, historyItem)]]">
+ <template is="dom-if" if="[[needsTimeGap_(index, historyItem, searchTerm)]]">
<div id="time-gap-separator"></div>
</template>
</template>

Powered by Google App Engine
This is Rietveld 408576698