chrome/browser/ui/webui/md_history_ui.cc - Issue 1643693003: MD History: Implement search functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/md_history_ui.cc

Issue 1643693003: MD History: Implement search functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded

Patch Set: Rebase and address reviewer comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_history/history_toolbar.js ('k') | chrome/test/data/webui/md_history/history_card_manager_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/md_history_ui.cc

diff --git a/chrome/browser/ui/webui/md_history_ui.cc b/chrome/browser/ui/webui/md_history_ui.cc

index 8f04fe4b0d665f2abcfa13d0077b90211373c3f0..f73847a7966651ffedaaf5c948a4e6be7345d1c3 100644

--- a/chrome/browser/ui/webui/md_history_ui.cc

+++ b/chrome/browser/ui/webui/md_history_ui.cc

@@ -35,15 +35,21 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {

content::WebUIDataSource::Create(chrome::kChromeUIHistoryHost);

// Localized strings (alphabetical order).

+ source->AddLocalizedString("cancel", IDS_CANCEL);

source->AddLocalizedString("clearBrowsingData",

IDS_CLEAR_BROWSING_DATA_TITLE);

source->AddLocalizedString("clearSearch", IDS_MD_HISTORY_CLEAR_SEARCH);

- source->AddLocalizedString("cancel", IDS_CANCEL);

source->AddLocalizedString("delete", IDS_MD_HISTORY_DELETE);

+ source->AddLocalizedString("foundSearchResults",

+ IDS_HISTORY_FOUND_SEARCH_RESULTS);

source->AddLocalizedString("itemsSelected", IDS_MD_HISTORY_ITEMS_SELECTED);

source->AddLocalizedString("moreFromSite", IDS_HISTORY_MORE_FROM_SITE);

+ source->AddLocalizedString("noResults", IDS_HISTORY_NO_RESULTS);

+ source->AddLocalizedString("noSearchResults", IDS_HISTORY_NO_SEARCH_RESULTS);

source->AddLocalizedString("removeFromHistory", IDS_HISTORY_REMOVE_PAGE);

source->AddLocalizedString("search", IDS_MD_HISTORY_SEARCH);

+ source->AddLocalizedString("searchResult", IDS_HISTORY_SEARCH_RESULT);

+ source->AddLocalizedString("searchResults", IDS_HISTORY_SEARCH_RESULTS);

source->AddLocalizedString("title", IDS_HISTORY_TITLE);

bool allow_deleting_history =