Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/resources/md_history/history_list.html

Issue 1643693003: MD History: Implement search functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded
Patch Set: Rebase and address reviewer comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/history_list.html
diff --git a/chrome/browser/resources/md_history/history_list.html b/chrome/browser/resources/md_history/history_list.html
index fdb1b1bb6cf0ba669559c8d25d65fd417f7f07ae..b0e547d2d33c5c3b7883b0d28302781dd2578c8a 100644
--- a/chrome/browser/resources/md_history/history_list.html
+++ b/chrome/browser/resources/md_history/history_list.html
@@ -13,6 +13,10 @@
flex-direction: column;
}
+ [hidden] {
+ display: none !important;
+ }
+
#overflow-menu {
@apply(--shadow-elevation-2dp);
border-radius: 2px;
@@ -40,21 +44,38 @@
paper-item:hover {
background: #eaeaea;
}
+
+ #no-results {
+ flex: 1;
+ align-items: center;
+ color: #b4b4b4;
+ display: flex;
+ font-size: 14px;
+ font-weight: 500;
+ justify-content: center;
+ }
</style>
+ <div id="no-results"
+ hidden$="{{!noResultsAvailable_(historyData.length, loading_)}}">
+ {{noResultsMessage_(searchTerm)}}
+ </div>
<iron-list items="{{historyData}}" as="historyDay" id="infinite-list"
- on-scroll="scrollHandler_">
+ on-scroll="scrollHandler_"
+ hidden$="{{noResultsAvailable_(historyData.length, loading_)}}">
<template>
<history-item history-date="[[historyDay.dateRelativeDay]]"
website-title="[[historyDay.title]]"
website-url="[[historyDay.url]]"
website-domain="[[historyDay.domain]]"
- time-accessed="[[historyDay.dateTimeOfDay]]"
+ visible-timestamp="[[historyDay.visibleTimestamp]]"
starred="[[historyDay.starred]]"
timestamp="[[historyDay.time]]"
selected="{{historyDay.selected}}"
is-card-start="[[historyDay.isFirstItem]]"
is-card-end="[[historyDay.isLastItem]]"
- has-time-gap="[[historyDay.needsTimeGap]]">
+ has-time-gap="[[historyDay.needsTimeGap]]"
+ search-term="[[searchTerm]]"
+ number-of-items="[[historyData.length]]">
</history-item>
</template>
</iron-list>
« no previous file with comments | « chrome/browser/resources/md_history/history_item.js ('k') | chrome/browser/resources/md_history/history_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698