chrome/test/data/webui/md_history/history_card_manager_test.js - Issue 1643693003: MD History: Implement search functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/md_history/history_card_manager_test.js

Issue 1643693003: MD History: Implement search functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded

Patch Set: Hide cards that haven't been rerendered from previous chrome.send(). Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/history_item.js ('K') | « chrome/browser/ui/webui/md_history_ui.cc ('k') | chrome/test/data/webui/md_history/history_toolbar_test.js » ('j') | chrome/test/data/webui/md_history/history_toolbar_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/md_history/history_card_manager_test.js

diff --git a/chrome/test/data/webui/md_history/history_card_manager_test.js b/chrome/test/data/webui/md_history/history_card_manager_test.js

index 82b36a5aa6c148cd6292c7239d3a810d6fc7ad67..2eef439ef5a819f12fb58a0ee441bc4ae788c73c 100644

--- a/chrome/test/data/webui/md_history/history_card_manager_test.js

+++ b/chrome/test/data/webui/md_history/history_card_manager_test.js

@@ -51,7 +51,7 @@ cr.define('md_history.history_card_manager_test', function() {

});

setup(function() {

- element.addNewResults(TEST_HISTORY_RESULTS);

+ element.addNewResults(TEST_HISTORY_RESULTS, '');

});

test('splitting items by day', function() {

@@ -70,7 +70,7 @@ cr.define('md_history.history_card_manager_test', function() {

element.historyDataByDay_[2].historyItems[1].url);

});

- test('cancelling selection of multiple items', function() {

+ test('cancelling selection of multiple items', function(done) {

tsergeant 2016/02/02 02:57:36 This should already be done, right? Make sure you

hsampson 2016/02/03 02:37:59 Done.

var toolbar = $('toolbar');

flush(function() {

@@ -89,7 +89,7 @@ cr.define('md_history.history_card_manager_test', function() {

assertTrue(element.historyDataByDay_[2].historyItems[0].selected);

assertTrue(element.historyDataByDay_[2].historyItems[1].selected);

- toolbar.clearSelection();

+ toolbar.onClearSelectionTap_();

// Make sure that clearing the selection updates both the array and

// the actual history-items affected.

@@ -100,11 +100,12 @@ cr.define('md_history.history_card_manager_test', function() {

assertFalse(items[0].$.checkbox.checked);

assertFalse(items[1].$.checkbox.checked);

+ done();

});

test('updating history results', function() {

- element.addNewResults(ADDITIONAL_RESULTS);

+ element.addNewResults(ADDITIONAL_RESULTS, '');

assertEquals(5, element.historyDataByDay_.length);