MD History: Implement search functionality.

chrome/browser/resources/md_history/history_card_manager.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-card-manager',
 
   properties: {
     // An array of objects sorted in reverse chronological order.
     // Each object has a date and the history items belonging to that date.
     historyDataByDay_: {
       type: Array,
       value: function() { return []; }
     },
+
     // The time of access of the last element of historyDataByDay_.
     lastVisitedTime: {
       type: Number,
       value: 0
     },
+
     menuOpen: {
       type: Boolean,
       value: false,
       reflectToAttribute: true
     },
+
     menuIdentifier: {
       type: Number,
       value: 0
+    },
+
+    searchTerm: {
+      type: String,
+      value: ''
+    },
+
+    // Message shown when no results available. Depends on searchTerm.
+    noResultsMessage: {

[tsergeant, 2016/02/02 02:57:36]

Can this be private?

[hsampson, 2016/02/03 02:37:58]

Done.

+      type: String,
+      value: ''
+    },
+
+    // Page waits until results have finished loading before displaying message.
+    loading: {

[tsergeant, 2016/02/02 02:57:36]

And this?

[hsampson, 2016/02/03 02:37:58]

Done.

+      type: Boolean,
+      value: false
     }
   },
 
   /** @const @private */
   X_OFFSET_: 30,
 
   listeners: {
     'tap': 'closeMenu',
     'toggle-menu': 'toggleMenu_'
   },
 
   /**
    * Closes the overflow menu.
    */
   closeMenu: function() {
     this.menuOpen = false;
   },
 
   /**
+   * Clear the page completely so the page can display new results (search).
+   */
+  resetHistoryResults: function() {
+    this.loading = true;
+    this.splice('historyDataByDay_', 0, this.historyDataByDay_.length);
+  },
+
+  /**
    * Opens the overflow menu unless the menu is already open and the same button
    * is pressed.
    * @param {Event} e The event with details of the menu item that was clicked.
    * @private
    */
   toggleMenu_: function(e) {
     var menu = this.$['overflow-menu'];
 
     // Menu closes if the same button is clicked.
     if (this.menuOpen && this.menuIdentifier == e.detail.accessTime) {
       this.menuOpen = false;
     } else {
       this.menuOpen = true;
       this.menuIdentifier = e.detail.accessTime;
 
       cr.ui.positionPopupAtPoint(e.detail.x + this.X_OFFSET_, e.detail.y, menu,
           cr.ui.AnchorType.BEFORE);
 
       menu.focus();
     }
   },
 
   /**
+   * Reformat the search results so they all have the same dateRelativeDay (will
+   * all display on the same card). Also so the date displays instead of time.
+   * @param {array<HistoryEntry>} results The new search results.
+   * @param {string} searchTerm The search term used to find these results.
+   */
+  reformatSearchResults_: function(results, searchTerm) {
+    for (i = 0; i < results.length; i++) {
+      results[i].dateRelativeDay = searchTerm;
+      results[i].dateTimeOfDay = results[i].dateShort;
+      results[i].historySearchTerm = searchTerm;

[tsergeant, 2016/02/02 02:57:36]

What's this? I don't see it anywhere else

[hsampson, 2016/02/03 02:37:58]

This is used in addNewResults() if the results returned are search results, as
the results get returned in a slightly different format.

+    }
+  },
+
+  /**
    * Split the newly updated history results into history items sorted via day
    * accessed.
    * @param {Array<HistoryEntry>} results The new history results.
+   * @param {string} searchTerm The search term used for chrome.send.
    */
-  addNewResults: function(results) {
-    if (results.length == 0)
+  addNewResults: function(results, searchTerm) {
+    this.searchTerm = searchTerm;
+    this.noResultsMessage_();
+
+    if (results.length == 0) {
+      this.loading = false;
       return;
+    }
+
+    if (searchTerm != '')
+      this.reformatSearchResults_(results, searchTerm);
 
     var dateSortedData = [];
     var historyItems = [];
     var currentDate = results[0].dateRelativeDay;
 
     for (var i = 0; i < results.length; i++) {
       if (currentDate == undefined)
         continue;
 
       results[i].selected = false;
       if (results[i].dateRelativeDay != currentDate) {
         this.appendHistoryData_(currentDate, historyItems);
         currentDate = results[i].dateRelativeDay;
         historyItems = [];
       }
       historyItems.push(results[i]);
     }
     if (currentDate != undefined)
       this.appendHistoryData_(currentDate, historyItems);
 
     this.lastVisitedTime = historyItems[historyItems.length - 1].time;
+    this.loading = false;
+    Polymer.dom.flush();
   },
 
   /**
    * Cycle through each entry in historyDataByDay_ and set all items to be
    * unselected.
    */
   unselectAllItems: function(overallItemCount) {
     var historyCardData = this.historyDataByDay_;
 
     for (var i = 0; i < historyCardData.length; i++) {
@@ skipping 13 matching lines @@
   /**
    * Adds the given items into historyDataByDay_. Adds items to the last
    * existing day if the date matches, creates a new element otherwise.
    * @param {string} date The date of the history items.
    * @param {Array<HistoryEntry>} historyItems The list of history items for the
    * current date.
    * @private
    */
   appendHistoryData_: function(date, historyItems) {
     var lastDay = this.historyDataByDay_.length - 1;
-    if (lastDay > 0 && date == this.historyDataByDay_[lastDay].date) {
+    if (lastDay >= 0 && date == this.historyDataByDay_[lastDay].date) {
       this.set('historyDataByDay_.' + lastDay + '.historyItems',
           this.historyDataByDay_[lastDay].historyItems.concat(historyItems));
     } else {
       this.push('historyDataByDay_', {
         date: date,
         historyItems: historyItems
       });
     }
   },
 
   /**
    * Called when the card manager is scrolled.
    * @private
    */
   scrollHandler_: function() {
     // Closes overflow menu on scroll.
     this.closeMenu();
-
     this.loadMoreIfAtEnd_();
   },
 
   /**
    * Requests the next list of results when the scrollbar is near the bottom
    * of the window.
    */
   loadMoreIfAtEnd_: function() {
     var scrollOffset = 10;
-    var scrollElem = this.$['infinite-list'];
+    var scrollElem = this.$$('#infinite-list');

[tsergeant, 2016/02/02 02:57:36]

If you use hidden$=, then you won't need to worry about this either.

[hsampson, 2016/02/03 02:37:58]

Done.

+    if ((scrollElem != undefined) && (scrollElem.scrollHeight <=
+         scrollElem.scrollTop + scrollElem.clientHeight + scrollOffset) &&
+        (scrollElem.scrollTop != 0)) {
+      chrome.send('queryHistory',
+          [this.searchTerm, 0, 0, this.lastVisitedTime, RESULTS_PER_PAGE]);
+    }
+  },
 
-    if (scrollElem.scrollHeight <=
-        scrollElem.scrollTop + scrollElem.clientHeight + scrollOffset) {
-      chrome.send('queryHistory',
-          ['', 0, 0, this.lastVisitedTime, RESULTS_PER_PAGE]);
-    }
+  /**
+   * True if there are no results available and the page has finished loading.
+   * @param {number} numberOfResults The length of historyDataByDay_.
+   * @return {boolean} Whether there are results to show.
+   * @private
+   */
+  noResults_: function(numberOfResults) {
+    return numberOfResults == 0 && !this.loading;
+  },
+
+  /**
+   * Sets the message displayed when there are no results. Displayed if there is
+   * no history at all or if the search returned no results.
+   * @private
+   */
+  noResultsMessage_: function() {
+    var messageId = this.searchTerm == '' ? 'noResults' : 'noSearchResults';
+    this.noResultsMessage = loadTimeData.getString(messageId);
   }
 });