Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/resources/md_history/history_card_manager.html

Issue 1643693003: MD History: Implement search functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded
Patch Set: Update comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">
5 <link rel="import" href="chrome://resources/html/cr/ui/position_util.html"> 5 <link rel="import" href="chrome://resources/html/cr/ui/position_util.html">
6 <link rel="import" href="chrome://history/history_card.html"> 6 <link rel="import" href="chrome://history/history_card.html">
7 7
8 <dom-module id="history-card-manager"> 8 <dom-module id="history-card-manager">
9 <template> 9 <template>
10 <style> 10 <style>
11 :host { 11 :host {
12 display: flex; 12 display: flex;
13 flex-direction: column; 13 flex-direction: column;
14 } 14 }
15 15
16 :host([menu-open]) #overflow-menu { 16 :host([menu-open]) #overflow-menu {
17 display: block; 17 display: block;
18 } 18 }
19 19
20 [hidden] {
21 display: none !important;
22 }
23
20 #overflow-menu { 24 #overflow-menu {
21 @apply(--shadow-elevation-2dp); 25 @apply(--shadow-elevation-2dp);
22 border-radius: 2px; 26 border-radius: 2px;
23 display: none; 27 display: none;
24 left: 0; 28 left: 0;
25 position: absolute; 29 position: absolute;
26 top: 0; 30 top: 0;
27 } 31 }
28 32
29 #infinite-list { 33 #infinite-list {
30 flex: 1; 34 flex: 1;
31 padding: 40px 0 0 0; 35 padding: 40px 0 0 0;
32 } 36 }
33 37
34 paper-item { 38 paper-item {
35 -webkit-user-select: none; 39 -webkit-user-select: none;
36 cursor: pointer; 40 cursor: pointer;
37 font: inherit; 41 font: inherit;
38 } 42 }
39 43
40 paper-item:hover { 44 paper-item:hover {
41 background: #eaeaea; 45 background: #eaeaea;
42 } 46 }
47
48 #no-results,
49 #no-search-results {
50 flex: 1;
51 align-items: center;
52 color: #b4b4b4;
53 display: flex;
54 font-size: 14px;
55 font-weight: 500;
56 justify-content: center;
57 }
43 </style> 58 </style>
59 <div id="no-results" i18n-content="noResults"
60 hidden$=
61 "{{resultsAvailable_(historyDataByDay_.length, loading_, searchTerm)}}">
62 </div>
63 <div id="no-search-results" i18n-content="noSearchResults"
64 hidden$=
65 "{{noSearch_(historyDataByDay_.length, loading_, searchTerm)}}">
66 </div>
44 <iron-list items="{{historyDataByDay_}}" as="historyDay" id="infinite-list" 67 <iron-list items="{{historyDataByDay_}}" as="historyDay" id="infinite-list"
45 on-scroll="scrollHandler_"> 68 on-scroll="scrollHandler_"
69 hidden$="{{noResultsAvailable_(historyDataByDay_.length, loading_)}}">
tsergeant 2016/02/09 04:28:53 As discussed, try to rename these functions so tha
hsampson 2016/02/11 02:46:26 Now that we have figured out how to get loadTimeDa
46 <template> 70 <template>
47 <history-card history-date="{{historyDay.date}}" 71 <history-card history-title="{{historyDay.cardTitle}}"
tsergeant 2016/02/09 04:28:53 As discussed, revert this back to passing down the
hsampson 2016/02/11 02:46:26 Done.
72 search-term="[[searchTerm]]"
48 history-items="{{historyDay.historyItems}}"> 73 history-items="{{historyDay.historyItems}}">
49 </history-card> 74 </history-card>
50 </template> 75 </template>
51 </iron-list> 76 </iron-list>
52 <paper-menu id="overflow-menu"> 77 <paper-menu id="overflow-menu">
53 <paper-item i18n-content="moreFromSite" on-tap="onMoreFromSiteTap_"> 78 <paper-item i18n-content="moreFromSite" on-tap="onMoreFromSiteTap_">
54 </paper-item> 79 </paper-item>
55 <paper-item i18n-content="removeFromHistory" 80 <paper-item i18n-content="removeFromHistory"
56 on-tap="onRemoveFromHistoryTap_"> 81 on-tap="onRemoveFromHistoryTap_">
57 </paper-item> 82 </paper-item>
58 </paper-menu> 83 </paper-menu>
59 </template> 84 </template>
60 <script src="chrome://history/history_card_manager.js"></script> 85 <script src="chrome://history/history_card_manager.js"></script>
61 </dom-module> 86 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698