Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5701)

Unified Diff: chrome/browser/extensions/extensions_service.h

Issue 164369: Merge 22244 - Try again to land: http://codereview.chromium.org/160483... (Closed) Base URL: svn://chrome-svn/chrome/branches/195/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_install_ui.cc ('k') | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extensions_service.h
===================================================================
--- chrome/browser/extensions/extensions_service.h (revision 23141)
+++ chrome/browser/extensions/extensions_service.h (working copy)
@@ -89,6 +89,8 @@
return &extensions_;
}
+ const FilePath& install_directory() const { return install_directory_; }
+
// Initialize and start all installed extensions.
void Init();
@@ -96,16 +98,14 @@
// update if an older version is already installed.
// For fresh installs, this method also causes the extension to be
// immediately loaded.
+ // TODO(aa): This method can be removed. It is only used by the unit tests,
+ // and they could use CrxInstaller directly instead.
void InstallExtension(const FilePath& extension_path);
- // XXX Hack: This is a temporary nasty hack to get theme installation working
- // without a dialog. Will be fixed by making ExtensionsService more modular.
- void InstallExtension(const FilePath& extension_path,
- const GURL& download_url,
- const GURL& referrer_url);
-
// Updates a currently-installed extension with the contents from
// |extension_path|.
+ // TODO(aa): This method can be removed. ExtensionUpdater could use
+ // CrxInstaller directly instead.
virtual void UpdateExtension(const std::string& id,
const FilePath& extension_path);
@@ -192,12 +192,6 @@
bool is_ready() { return ready_; }
private:
- // Show a confirm installation infobar on the currently active tab.
- // TODO(aa): This should be moved up into the UI and attached to the tab it
- // actually occured in. This requires some modularization of
- // ExtensionsService.
- bool ShowThemePreviewInfobar(Extension* extension);
-
// The profile this ExtensionsService is part of.
Profile* profile_;
Property changes on: chrome\browser\extensions\extensions_service.h
___________________________________________________________________
Modified: svn:mergeinfo
Merged /trunk/src/chrome/browser/extensions/extensions_service.h:r22244
« no previous file with comments | « chrome/browser/extensions/extension_install_ui.cc ('k') | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698