Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1643633004: Improvements to GYP build (Closed)

Created:
4 years, 10 months ago by labath
Modified:
4 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improvements to GYP build This updates the GYP build for the processor component (on windows). - adds/removes references to files which were added or removed from the repository - includes build/common.gypi in the gyp files: needed to correctly detect the OS (I think, the generated MSVC solutions were broken without it) - conditionally compiles code platform-specific code for the given platform After this minidump processor nearly compiles with VS2013: the generated project is correct, but some files still have compilation errors. Disclaimer: I have not tested the GYP changes on non-windows platform, as there does not seem to be anyone using it there. BUG= R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/4003d20c70ec0fca08b2f5be833ef08556fb862d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/common/common.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/processor/processor.gyp View 4 chunks +2 lines, -3 lines 0 comments Download
M src/third_party/libdisasm/libdisasm.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
labath
4 years, 10 months ago (2016-01-28 15:07:36 UTC) #2
Mark Mentovai
LGTM with these changes. I’ve made you a Breakpad committer, so you’ll be able to ...
4 years, 10 months ago (2016-01-28 17:29:22 UTC) #3
labath
4 years, 10 months ago (2016-01-29 11:43:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4003d20c70ec0fca08b2f5be833ef08556fb862d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698