Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: chrome/BUILD.gn

Issue 1643633003: Link Blink into the browser process less. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: safe json Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/copresence/BUILD.gn » ('j') | components/guest_view/browser/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index db8d6d6f876072ee5b8eacf7a7c140d8209fd902..d5b0f145c7f3b8b5d1b885116e1f44c6f89e1b55 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -458,6 +458,19 @@ group("browser_dependencies") {
public_deps += [ "//chrome/service" ]
}
}
+
+ if (!is_component_build) {
+ assert_no_deps = [
+ # Blink and V8 should not be used in the browser process. In component
+ # build this is OK because all of content is linked into one library.
+ # Note that the blink_headers target is OK, so we can't doa wildcard for
Dirk Pranke 2016/01/28 01:54:30 s/doa/do a/
+ # all blink targets.
+ "//third_party/WebKit/public:blink",
+ # TODO(brettw) bug 581766: V8 should not be linked into the browser
+ # process, and then we can enable this.
+ #"//v8/*",
+ ]
+ }
}
# GYP version: chromium_child_dependencies variable in chrome.gyp
« no previous file with comments | « no previous file | components/copresence/BUILD.gn » ('j') | components/guest_view/browser/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698