Only add -isystem for libc++ for C++ files, not C files.

Only add -isystem for libc++ for C++ files, not C files.

Seems cleaner.  libc++ recently added a few headers that shadow
C headers, and shouldn't pick those up when building C files.

BUG=none
R=sammc@chromium.org

Committed: be55b9ad86a4a5f760895984f93f76038e08e29e

[Nico, 2016-01-27 18:12:45]

thakis@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2016-01-27 22:43:30]

https://codereview.chromium.org/1643613002/diff/1/third_party/libc++/BUILD.gn
File third_party/libc++/BUILD.gn (right):

https://codereview.chromium.org/1643613002/diff/1/third_party/libc++/BUILD.gn...
third_party/libc++/BUILD.gn:94: cflags_cc = [
This config is only used by binaries and shared library targets.
//build/config/sanitizers:default_sanitizer_flags sets the include paths for
everything else.

[Nico, 2016-01-27 22:54:00]

https://codereview.chromium.org/1643613002/diff/1/third_party/libc++/BUILD.gn
File third_party/libc++/BUILD.gn (right):

https://codereview.chromium.org/1643613002/diff/1/third_party/libc++/BUILD.gn...
third_party/libc++/BUILD.gn:94: cflags_cc = [
On 2016/01/27 22:43:30, Sam McNally wrote:
> This config is only used by binaries and shared library targets.
> //build/config/sanitizers:default_sanitizer_flags sets the include paths for
> everything else.

Oh, thanks!
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/sanit...
is wrong then :-) Removed this and added a comment.


Do you know why this is done that way though? buildtools/ exists so that v8/ can
use it, and now it can't use the sanitizers/BUILD.gn bits.

[Sam McNally, 2016-01-27 23:15:34]

On 2016/01/27 22:54:00, Nico wrote:
> https://codereview.chromium.org/1643613002/diff/1/third_party/libc++/BUILD.gn
> File third_party/libc++/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1643613002/diff/1/third_party/libc++/BUILD.gn...
> third_party/libc++/BUILD.gn:94: cflags_cc = [
> On 2016/01/27 22:43:30, Sam McNally wrote:
> > This config is only used by binaries and shared library targets.
> > //build/config/sanitizers:default_sanitizer_flags sets the include paths for
> > everything else.
> 
> Oh, thanks!
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/sanit...
> is wrong then :-) Removed this and added a comment.

LGTM
> 
> 
> Do you know why this is done that way though? buildtools/ exists so that v8/
can
> use it, and now it can't use the sanitizers/BUILD.gn bits.

I don't know. I believe gn is only supported for chromium-embedded v8 though.

[Nico, 2016-01-28 15:22:30]

Description was changed from

==========
Only add -isystem for libc++ for C++ files, not C files.

Seems cleaner.  libc++ recently added a few headers that shadow
C headers, and shouldn't pick those up when building C files.

BUG=none
==========

to

==========
Only add -isystem for libc++ for C++ files, not C files.

Seems cleaner.  libc++ recently added a few headers that shadow
C headers, and shouldn't pick those up when building C files.

BUG=none
R=sammc@chromium.org

Committed: be55b9ad86a4a5f760895984f93f76038e08e29e
==========

[Nico, 2016-01-28 15:22:31]

Committed patchset #2 (id:20001) manually as
be55b9ad86a4a5f760895984f93f76038e08e29e (presubmit successful).