Refcounting BufferedResourceLoader

Refcounting BufferedResourceLoader

BUG=18677
We do range request for <video> and <audio>, we used
to destroy the ResourceLoaderBridge right after we
cancel the request. But it turns out that this would
leave an excessive amount of warnings in the renderer
and also leaking of URLRequest in the browser.

By refcounting BufferedResourceLoader (the container
of ResourceLoaderBridge) that does resource loading
for <video>, we can then destroy the
ResourceLoaderBridge after request has completed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23274

[Alpha Left Google, 2009-08-11 23:55:50]

Restarting the change here because I used the wonderful linux to upload this. :)

[scherkus (not reviewing), 2009-08-13 00:10:00]

http://codereview.chromium.org/164361/diff/1/4
File webkit/glue/media/buffered_data_source_unittest.cc (right):

http://codereview.chromium.org/164361/diff/1/4#newcode39
Line 39: ACTION_P(RequestCanceled, loader) {
comment what this does

http://codereview.chromium.org/164361/diff/1/4#newcode139
Line 139: void ExpectCancelLoader() {
is this used anywhere?

http://codereview.chromium.org/164361/diff/1/4#newcode541
Line 541: EXPECT_TRUE(loader_ != NULL);
nit: with scoped_refptr you do EXPECT_TRUE(loader_) etc

http://codereview.chromium.org/164361/diff/1/4#newcode564
Line 564: EXPECT_TRUE(loader_ != NULL);
same

http://codereview.chromium.org/164361/diff/1/4#newcode606
Line 606: EXPECT_TRUE(loader_ != NULL);
and here

[Alpha Left Google, 2009-08-13 00:51:16]

http://codereview.chromium.org/164361/diff/1/4
File webkit/glue/media/buffered_data_source_unittest.cc (right):

http://codereview.chromium.org/164361/diff/1/4#newcode39
Line 39: ACTION_P(RequestCanceled, loader) {
On 2009/08/13 00:10:01, scherkus wrote:
> comment what this does

Done.

http://codereview.chromium.org/164361/diff/1/4#newcode139
Line 139: void ExpectCancelLoader() {
On 2009/08/13 00:10:01, scherkus wrote:
> is this used anywhere?

Done.

[scherkus (not reviewing), 2009-08-13 00:52:08]

LGTM