Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: src/x87/assembler-x87-inl.h

Issue 1643573003: Call RecordWriteIntoCode in RelocInfo::set_target_cell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 WriteBarrierMode write_barrier_mode, 197 WriteBarrierMode write_barrier_mode,
198 ICacheFlushMode icache_flush_mode) { 198 ICacheFlushMode icache_flush_mode) {
199 DCHECK(cell->IsCell()); 199 DCHECK(cell->IsCell());
200 DCHECK(rmode_ == RelocInfo::CELL); 200 DCHECK(rmode_ == RelocInfo::CELL);
201 Address address = cell->address() + Cell::kValueOffset; 201 Address address = cell->address() + Cell::kValueOffset;
202 Memory::Address_at(pc_) = address; 202 Memory::Address_at(pc_) = address;
203 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 203 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
204 Assembler::FlushICache(isolate_, pc_, sizeof(Address)); 204 Assembler::FlushICache(isolate_, pc_, sizeof(Address));
205 } 205 }
206 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL) { 206 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL) {
207 // TODO(1550) We are passing NULL as a slot because cell can never be on 207 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(host(), this,
208 // evacuation candidate. 208 cell);
209 host()->GetHeap()->incremental_marking()->RecordWrite(
210 host(), NULL, cell);
211 } 209 }
212 } 210 }
213 211
214 212
215 Handle<Object> RelocInfo::code_age_stub_handle(Assembler* origin) { 213 Handle<Object> RelocInfo::code_age_stub_handle(Assembler* origin) {
216 DCHECK(rmode_ == RelocInfo::CODE_AGE_SEQUENCE); 214 DCHECK(rmode_ == RelocInfo::CODE_AGE_SEQUENCE);
217 DCHECK(*pc_ == kCallOpcode); 215 DCHECK(*pc_ == kCallOpcode);
218 return Memory::Object_Handle_at(pc_ + 1); 216 return Memory::Object_Handle_at(pc_ + 1);
219 } 217 }
220 218
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 551
554 Operand::Operand(Immediate imm) { 552 Operand::Operand(Immediate imm) {
555 // [disp/r] 553 // [disp/r]
556 set_modrm(0, ebp); 554 set_modrm(0, ebp);
557 set_dispr(imm.x_, imm.rmode_); 555 set_dispr(imm.x_, imm.rmode_);
558 } 556 }
559 } // namespace internal 557 } // namespace internal
560 } // namespace v8 558 } // namespace v8
561 559
562 #endif // V8_X87_ASSEMBLER_X87_INL_H_ 560 #endif // V8_X87_ASSEMBLER_X87_INL_H_
OLDNEW
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698