tools/metrics/histograms/histograms.xml - Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments for patchsets #3 and #4 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index b5a898b6df1e8505268736b6a8fad01ac19d7137..f1f0feeb99b8a959b7f953c66246a97f494882ec 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -42543,6 +42543,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="SBIRS.SuspiciousModuleDetectionTime" units="ms">

+ <owner>proberge@google.com</owner>

+ <summary>

+ The elapsed time to check loaded modules against the module whitelist.

+ </summary>

+</histogram>

+<histogram name="SBIRS.SuspiciousModuleReportCount">

+ <owner>proberge@google.com</owner>

+ <summary>The number of suspicious modules found.</summary>

+</histogram>

+<histogram name="SBIRS.SuspiciousModuleReportingTime" units="ms">

+ <owner>proberge@google.com</owner>

+ <summary>

+ The elapsed time to create incidents for suspicious modules.

+ </summary>

+</histogram>

<owner>caitkp@google.com</owner>

« chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win_unittest.cc ('K') | « components/safe_browsing_db/util.cc ('k') | no next file » | no next file with comments »