components/safe_browsing_db/database_manager.h - Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/database_manager.h

Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only enable for extended reporting AND feature flag. Add unit test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/safe_browsing_database.cc ('K') | « chrome/common/safe_browsing/csd.proto ('k') | components/safe_browsing_db/test_database_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/database_manager.h

diff --git a/components/safe_browsing_db/database_manager.h b/components/safe_browsing_db/database_manager.h

index 4924cacb32503fd883bdb906f0c620691e6205af..32efe097119b77e93b080eff76e46222b6f5d93e 100644

--- a/components/safe_browsing_db/database_manager.h

+++ b/components/safe_browsing_db/database_manager.h

@@ -118,6 +118,12 @@ class SafeBrowsingDatabaseManager

// error occurs. This method must be called on the IO thread.

virtual bool MatchInclusionWhitelistUrl(const GURL& url) = 0;

+ // Check if |str| matches any of the full-length hashes from the module

+ // whitelist. Returns true if there was a match and false otherwise. To make

+ // sure we are conservative we will return true if an error occurs. This

+ // method must be called on the IO thread.

+ virtual bool MatchModuleWhitelistString(const std::string& str) = 0;

// Check if the CSD malware IP matching kill switch is turned on.

virtual bool IsMalwareKillSwitchOn() = 0;