Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only enable for extended reporting AND feature flag. Add unit test. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index ed7aea9c178938f31eaa22adadd4ce3d84688f3b..a6eecea1378fd2ee78118b5f109e792a30f70bc7 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -63,6 +63,7 @@
#include "chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h"
#include "chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer.h"
#include "chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h"
+#include "chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.h"
#include "chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h"
#include "chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.h"
#endif
@@ -240,6 +241,7 @@ void SafeBrowsingService::Initialize() {
incident_service_.reset(CreateIncidentReportingService());
resource_request_detector_.reset(new ResourceRequestDetector(
incident_service_->GetIncidentReceiver()));
+ module_load_analyzer_.reset(new ModuleLoadAnalyzer(database_manager_));
#endif // !defined(FULL_SAFE_BROWSING)
// Track the safe browsing preference of existing profiles.
@@ -287,6 +289,7 @@ void SafeBrowsingService::ShutDown() {
#if defined(FULL_SAFE_BROWSING)
resource_request_detector_.reset();
incident_service_.reset();
+ module_load_analyzer_.reset();
#endif
download_service_.reset();
@@ -357,6 +360,12 @@ void SafeBrowsingService::RegisterDelayedAnalysisCallback(
const DelayedAnalysisCallback& callback) {
incident_service_->RegisterDelayedAnalysisCallback(callback);
}
+
+void SafeBrowsingService::RegisterExtendedReportingOnlyDelayedAnalysisCallback(
+ const DelayedAnalysisCallback& callback) {
+ incident_service_->RegisterExtendedReportingOnlyDelayedAnalysisCallback(
+ callback);
+}
#endif
void SafeBrowsingService::AddDownloadManager(

Powered by Google App Engine
This is Rietveld 408576698