Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.cc

Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only enable for extended reporting AND feature flag. Add unit test. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.cc b/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f65f618d5ed46eee0b785de89597a15a359adc01
--- /dev/null
+++ b/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.cc
@@ -0,0 +1,57 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.h"
+
+#include "build/build_config.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/safe_browsing/incident_reporting/incident_receiver.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
+
+namespace safe_browsing {
+
+#if defined(OS_WIN)
robertshield 2016/02/05 21:20:32 would prefer to have this in the _win.cc file. Thi
proberge 2016/02/05 22:26:10 Done.
+// Enables automatic tab discarding, when the system is in low memory state.
+const base::Feature kIncidentReportingModuleLoadAnalysis{
+ "IncidentReportingModuleLoadAnalysis", base::FEATURE_DISABLED_BY_DEFAULT};
+#endif // defined(OS_WIN)
+
+ModuleLoadAnalyzer::ModuleLoadAnalyzer(
+ const scoped_refptr<SafeBrowsingDatabaseManager>& database_manager)
+ : incident_receiver_(nullptr),
+ database_manager_(database_manager),
+ abort_reporting_(false) {
+ DCHECK(database_manager);
+#if defined(OS_WIN)
+ if (base::FeatureList::IsEnabled(kIncidentReportingModuleLoadAnalysis)) {
+ scoped_refptr<SafeBrowsingService> safe_browsing_service(
+ g_browser_process->safe_browsing_service());
+
+ if (safe_browsing_service) {
+ safe_browsing_service
+ ->RegisterExtendedReportingOnlyDelayedAnalysisCallback(
+ base::Bind(&ModuleLoadAnalyzer::VerifyModuleLoadState,
+ base::Unretained(this)));
+ }
+ }
+#endif // defined(OS_WIN)
+}
+
+ModuleLoadAnalyzer::~ModuleLoadAnalyzer() {
+ abort_reporting_ = true;
+}
+
+#if !defined(OS_WIN)
+void ModuleLoadAnalyzer::GetLoadedSuspiciousModulesOnIOThread() {}
+
+void ModuleLoadAnalyzer::ReportIncidentsForSuspiciousModules(
+ scoped_ptr<std::set<base::string16>> module_names) {}
+
+bool ModuleLoadAnalyzer::VerifyModuleLoadState(
+ scoped_ptr<IncidentReceiver> incident_receiver) {
+ return false;
+}
+#endif // !defined(OS_WIN)
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698