Add a ModuleLoadAnalyzer which checks modules against a whitelist

chrome/browser/safe_browsing/incident_reporting/incident.h

Index: chrome/browser/safe_browsing/incident_reporting/incident.h
diff --git a/chrome/browser/safe_browsing/incident_reporting/incident.h b/chrome/browser/safe_browsing/incident_reporting/incident.h
index 2fa84c9cfb8bf8fef20a249baaae7c2b50c50518..970e17d8c103d3acdd4bcdef0aedf4335828e4e5 100644
--- a/chrome/browser/safe_browsing/incident_reporting/incident.h
+++ b/chrome/browser/safe_browsing/incident_reporting/incident.h
@@ -27,8 +27,16 @@ enum class IncidentType : int32_t {
   OMNIBOX_INTERACTION = 4,
   VARIATIONS_SEED_SIGNATURE = 5,
   RESOURCE_REQUEST = 6,
+  SUSPICIOUS_MODULE = 7,
   // Values for new incident types go here.
-  NUM_TYPES = 7
+  NUM_TYPES = 8
+};
+
+// The level of consent required by the incident to be associated with a
+// profile. Please keep this list in ascending order of privacy consent.

[grt (UTC plus 2), 2016/02/15 16:46:50]

nit: the ordering requirement isn't a gentle request, is it? "The list must be
ordered by increasing privacy consent." or something like that. if it is not a
requirement, then there's no need to make any mention of the ordering.

[proberge, 2016/02/16 16:56:22]

Done.

+enum class MinimumProfileConsent : int32_t {

[grt (UTC plus 2), 2016/02/15 16:46:49]

omit " : int32_t" unless it's really required. in the case of the incident type,
it is. for this, i'm not so sure.

[proberge, 2016/02/16 16:56:22]

Done.

+  SAFE_BROWSING_ENABLED = 0,
+  SAFE_BROWSING_EXTENDED_REPORTING_ENABLED = 1,
 };
 
 // An abstract incident. Subclasses provide type-specific functionality to
@@ -51,6 +59,8 @@ class Incident {
   // Returns the incident's payload.
   virtual scoped_ptr<ClientIncidentReport_IncidentData> TakePayload();
 
+  virtual MinimumProfileConsent GetMinimumProfileConsent() const;

[grt (UTC plus 2), 2016/02/15 16:46:49]

  // Returns the minimum level of consent required for reporting of the
incident.
or something like that

[proberge, 2016/02/16 16:56:22]

Done.

+
  protected:
   // Constructs the payload with an empty protobuf, setting its incident time to
   // the current time.