chrome/browser/safe_browsing/local_database_manager.h - Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/local_database_manager.h

Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: abort_reporting to static field, add test for shutdown case Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident_unittest.cc ('k') | chrome/browser/safe_browsing/local_database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/local_database_manager.h

diff --git a/chrome/browser/safe_browsing/local_database_manager.h b/chrome/browser/safe_browsing/local_database_manager.h

index fd9712ba935e37c89ad8d05d0b901034906ce964..ef543e9c338b0f4b75342ce0443345caa53d3b07 100644

--- a/chrome/browser/safe_browsing/local_database_manager.h

+++ b/chrome/browser/safe_browsing/local_database_manager.h

@@ -120,6 +120,7 @@ class LocalSafeBrowsingDatabaseManager

bool MatchDownloadWhitelistUrl(const GURL& url) override;

bool MatchDownloadWhitelistString(const std::string& str) override;

bool MatchInclusionWhitelistUrl(const GURL& url) override;

+ bool MatchModuleWhitelistString(const std::string& str) override;

bool IsMalwareKillSwitchOn() override;

bool IsCsdWhitelistKillSwitchOn() override;

void CancelCheck(Client* client) override;

@@ -344,6 +345,9 @@ class LocalSafeBrowsingDatabaseManager

// Indicate if the unwanted software blacklist should be enabled.

bool enable_unwanted_software_blacklist_;

+ // Indicate if the module whitelist should be enabled.

+ bool enable_module_whitelist_;

// The sequenced task runner for running safe browsing database operations.

scoped_refptr<base::SequencedTaskRunner> safe_browsing_task_runner_;