Add a ModuleLoadAnalyzer which checks modules against a whitelist

chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident_unittest.cc

-// Copyright 2015 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h"
+#include "chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident.h"
 
 #include <utility>
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/common/safe_browsing/csd.pb.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace safe_browsing {
 
 namespace {
 
 scoped_ptr<Incident> MakeIncident(const char* digest) {
-  scoped_ptr<ClientIncidentReport_IncidentData_BlacklistLoadIncident> incident(
-      new ClientIncidentReport_IncidentData_BlacklistLoadIncident);
+  scoped_ptr<ClientIncidentReport_IncidentData_SuspiciousModuleIncident>
+      incident(new ClientIncidentReport_IncidentData_SuspiciousModuleIncident);
   incident->set_path("foo");
-  return make_scoped_ptr(new BlacklistLoadIncident(std::move(incident)));
+  return make_scoped_ptr(new SuspiciousModuleIncident(std::move(incident)));
 }
 
 }  // namespace
 
-TEST(BlacklistLoadIncident, GetType) {
-  ASSERT_EQ(IncidentType::BLACKLIST_LOAD, MakeIncident("37")->GetType());
+TEST(SuspiciousModuleIncident, GetType) {
+  ASSERT_EQ(IncidentType::SUSPICIOUS_MODULE, MakeIncident("37")->GetType());
 }
 
 // Tests that GetKey returns the dll path.
-TEST(BlacklistLoadIncident, KeyIsPath) {
+TEST(SuspiciousModuleIncident, KeyIsPath) {
   ASSERT_EQ(std::string("foo"), MakeIncident("37")->GetKey());
 }
 
 // Tests that GetDigest returns the same value for the same incident.
-TEST(BlacklistLoadIncident, SameIncidentSameDigest) {
+TEST(SuspiciousModuleIncident, SameIncidentSameDigest) {
   ASSERT_EQ(MakeIncident("37")->ComputeDigest(),
             MakeIncident("37")->ComputeDigest());
 }
 
 // Tests that GetDigest returns different values for different incidents.
-TEST(BlacklistLoadIncident, DifferentIncidentDifferentDigest) {
+TEST(SuspiciousModuleIncident, DifferentIncidentDifferentDigest) {
   ASSERT_EQ(MakeIncident("37")->ComputeDigest(),

[grt (UTC plus 2), 2016/02/18 16:06:55]

this test is broken:
- this should be ASSERT_NE since the intent is that incidents with different
payloads result in different digests
- MakeIncident() ignores its param, unconditionally returning identical
payloads, which is not the intent

[proberge, 2016/02/18 18:44:40]

Good catch. It looks like blacklist_load_incident_unittest has a similar issue.
Fixed it for both.

             MakeIncident("42")->ComputeDigest());
 }
 
 }  // namespace safe_browsing