Add a ModuleLoadAnalyzer which checks modules against a whitelist

chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.h"
+
+#include "build/build_config.h"
+#include "chrome/browser/browser_process.h"

[grt (UTC plus 2), 2016/02/11 15:54:59]

unused

[proberge, 2016/02/11 20:25:21]

Re-used when moving the logic of RegisterModuleLoadAnalysis here once more

+#include "chrome/browser/safe_browsing/incident_reporting/incident_receiver.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"

[grt (UTC plus 2), 2016/02/11 15:55:00]

unused

[proberge, 2016/02/11 20:25:21]

Re-used when moving the logic of RegisterModuleLoadAnalysis here once more

+
+namespace safe_browsing {
+
+#if !defined(OS_WIN)
+void RegisterModuleLoadAnalysis(

[grt (UTC plus 2), 2016/02/11 15:54:59]

this re-declares the function. you really want to define it with:
void RegisterModuleLoadAnalysis(
    const scoped_refptr<SafeBrowsingDatabaseManager>&) {
}

[proberge, 2016/02/11 20:25:21]

Done.

+    const scoped_refptr<SafeBrowsingDatabaseManager>& database_manager);
+void VerifyModuleLoadState(
+    const scoped_refptr<SafeBrowsingDatabaseManager>& database_manager,
+    scoped_ptr<IncidentReceiver> incident_receiver);
+void GetLoadedSuspiciousModulesOnIOThread(

[grt (UTC plus 2), 2016/02/11 15:54:59]

get rid of these

[proberge, 2016/02/11 20:25:21]

Done.

+    const scoped_refptr<SafeBrowsingDatabaseManager>& database_manager,
+    scoped_ptr<IncidentReceiver> incident_receiver,
+    scoped_ptr<std::set<ModuleInfo>> module_info_set);
+void ReportIncidentsForSuspiciousModules(
+    scoped_ptr<std::set<base::string16>> module_names,
+    scoped_ptr<IncidentReceiver> incident_receiver);
+
+#endif  // !defined(OS_WIN)
+
+}  // namespace safe_browsing