Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1643563002: [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. (Closed)

Created:
4 years, 11 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. BUG= Committed: https://crrev.com/85aba7df84d397c7e47537292e6895bd8b26f440 Cr-Commit-Position: refs/heads/master@{#33613}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -35 lines) Patch
M src/api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +12 lines, -13 lines 0 comments Download
M src/objects.cc View 4 chunks +13 lines, -17 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Toon Verwaest
ptal
4 years, 11 months ago (2016-01-27 15:50:55 UTC) #2
Igor Sheludko
lgtm
4 years, 10 months ago (2016-01-29 12:20:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643563002/20001
4 years, 10 months ago (2016-01-29 14:24:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 14:55:21 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/85aba7df84d397c7e47537292e6895bd8b26f440 Cr-Commit-Position: refs/heads/master@{#33613}
4 years, 10 months ago (2016-01-29 14:55:47 UTC) #8
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1650033003/ by machenbach@chromium.org. ...
4 years, 10 months ago (2016-01-29 18:48:22 UTC) #9
Michael Achenbach
4 years, 10 months ago (2016-01-29 19:28:03 UTC) #10
Message was sent while issue was closed.
On 2016/01/29 18:48:22, Michael Achenbach wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1650033003/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Speculative revert for breaking webkit
> unit tests:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

The revert helped. So this looks like it was the cause.

Powered by Google App Engine
This is Rietveld 408576698