Issue 164356: Add disabled play and mute icons for media player.

Issue 164356: Add disabled play and mute icons for media player. (Closed)

Created:
11 years, 4 months ago by kylep

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google, awong, scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, kylep, awong, darin (slow to review), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add disabled play and mute icons for media player. BUG=18969, 18970 TEST=none Commited revision 23415. Failed to close this review so revision number added manually.

Patch Set 3 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
A	webkit/glue/resources/media_play_disabled.png	View		Binary file		0 comments	Download
A	webkit/glue/resources/media_sound_disabled.png	View		Binary file		0 comments	Download
M	webkit/glue/webkit_resources.grd	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webmediaplayer_impl.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kylep

Chromium side changes to add the play and sound disabled buttons. Webkit side play functionality ...

11 years, 4 months ago (2009-08-11 23:06:47 UTC) #1

scherkus (not reviewing)

LGTM -- alpha/albert care to double check?

11 years, 4 months ago (2009-08-11 23:11:12 UTC) #2

Alpha Left Google

LGTM, just have some nits. http://codereview.chromium.org/164356/diff/1/2 File webkit/glue/webkitclient_impl.cc (right): http://codereview.chromium.org/164356/diff/1/2#newcode167 Line 167: { "mediaSoundDisabled", IDR_MEDIA_SOUND_DISABLED ...

11 years, 4 months ago (2009-08-11 23:13:59 UTC) #3

kylep

http://codereview.chromium.org/164356/diff/1/2 File webkit/glue/webkitclient_impl.cc (right): http://codereview.chromium.org/164356/diff/1/2#newcode167 Line 167: { "mediaSoundDisabled", IDR_MEDIA_SOUND_DISABLED }, On 2009/08/11 23:14:00, Alpha ...

11 years, 4 months ago (2009-08-12 00:57:41 UTC) #4

scherkus (not reviewing)

11 years, 4 months ago (2009-08-12 02:13:35 UTC) #5

LGTM you can submit after addressing nit

http://codereview.chromium.org/164356/diff/1011/12
File webkit/glue/webkitclient_impl.cc (right):

http://codereview.chromium.org/164356/diff/1011/12#newcode163
Line 163: { "mediaPlayDisabled", IDR_MEDIA_PLAY_BUTTON_DISABLED },
nit: should be moved up one more slot to be beside play :)

Expand Messages | Collapse Messages