Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1643533003: Revert of Type Feedback Vector lives in the closure (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1142 matching lines...) Expand 10 before | Expand all | Expand 10 after
1153 1153
1154 1154
1155 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info, 1155 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info,
1156 bool pretenure) { 1156 bool pretenure) {
1157 // Use the fast case closure allocation code that allocates in new 1157 // Use the fast case closure allocation code that allocates in new
1158 // space for nested functions that don't need literals cloning. If 1158 // space for nested functions that don't need literals cloning. If
1159 // we're running with the --always-opt or the --prepare-always-opt 1159 // we're running with the --always-opt or the --prepare-always-opt
1160 // flag, we need to use the runtime function so that the new function 1160 // flag, we need to use the runtime function so that the new function
1161 // we are creating here gets a chance to have its code optimized and 1161 // we are creating here gets a chance to have its code optimized and
1162 // doesn't just get a copy of the existing unoptimized code. 1162 // doesn't just get a copy of the existing unoptimized code.
1163 if (!FLAG_always_opt && !FLAG_prepare_always_opt && !pretenure && 1163 if (!FLAG_always_opt &&
1164 scope()->is_function_scope()) { 1164 !FLAG_prepare_always_opt &&
1165 !pretenure &&
1166 scope()->is_function_scope() &&
1167 info->num_literals() == 0) {
1165 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind()); 1168 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind());
1166 __ Move(rbx, info); 1169 __ Move(rbx, info);
1167 __ CallStub(&stub); 1170 __ CallStub(&stub);
1168 } else { 1171 } else {
1169 __ Push(info); 1172 __ Push(info);
1170 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured 1173 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured
1171 : Runtime::kNewClosure); 1174 : Runtime::kNewClosure);
1172 } 1175 }
1173 context()->Plug(rax); 1176 context()->Plug(rax);
1174 } 1177 }
(...skipping 3540 matching lines...) Expand 10 before | Expand all | Expand 10 after
4715 Assembler::target_address_at(call_target_address, 4718 Assembler::target_address_at(call_target_address,
4716 unoptimized_code)); 4719 unoptimized_code));
4717 return OSR_AFTER_STACK_CHECK; 4720 return OSR_AFTER_STACK_CHECK;
4718 } 4721 }
4719 4722
4720 4723
4721 } // namespace internal 4724 } // namespace internal
4722 } // namespace v8 4725 } // namespace v8
4723 4726
4724 #endif // V8_TARGET_ARCH_X64 4727 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698