Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: lib/src/options.dart

Issue 1643523008: fix #43, remove => workaround (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/js/printer.dart ('k') | test/codegen/expect/collection/src/wrappers.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index 7f030a3877f81edd1f8dce3c61110fbb7363c291..65938e83b892f68bf5bdce2b84d548f0e2c1c8f9 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -77,10 +77,6 @@ class CodegenOptions {
/// Enable ES6 destructuring of named parameters.
final bool destructureNamedParams;
- /// Whether to emit a workaround for missing arrow function bind-this in
- /// other V8 builds
- final bool arrowFnBindThisWorkaround;
-
/// Which module format to support.
/// Currently 'es6' and 'legacy' are supported.
final ModuleFormat moduleFormat;
@@ -91,7 +87,6 @@ class CodegenOptions {
this.closure: _CLOSURE_DEFAULT,
this.destructureNamedParams: _DESTRUCTURE_NAMED_PARAMS_DEFAULT,
this.outputDir,
- this.arrowFnBindThisWorkaround: false,
this.moduleFormat: ModuleFormat.legacy});
}
@@ -240,7 +235,6 @@ CompilerOptions parseOptions(List<String> argv, {bool forceOutDir: false}) {
closure: args['closure'],
destructureNamedParams: args['destructure-named-params'],
outputDir: outputDir,
- arrowFnBindThisWorkaround: args['arrow-fn-bind-this'],
moduleFormat: parseModuleFormat(args['modules'])),
sourceOptions: new SourceResolverOptions(
useMockSdk: args['mock-sdk'],
@@ -304,8 +298,6 @@ final ArgParser argParser = new ArgParser()
help: 'Whether to emit source map files', defaultsTo: true)
..addOption('runtime-dir',
help: 'Where to find dev_compiler\'s runtime files', defaultsTo: null)
- ..addFlag('arrow-fn-bind-this',
- help: 'Work around `this` binding in => functions')
..addOption('modules',
help: 'Which module pattern to emit',
allowed: ModuleFormat.values.map(getEnumName).toList(),
« no previous file with comments | « lib/src/js/printer.dart ('k') | test/codegen/expect/collection/src/wrappers.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698