Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Issue 1643523008: fix #43, remove => workaround (Closed)

Created:
4 years, 10 months ago by Jennifer Messerly
Modified:
4 years, 10 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #43, remove => workaround also fixes node.js test to use a temp directory, instead of creating "tmp" under dev_compiler checkout R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/22e01a24224ee0af2a1bd937570f3f9dd6e2f83d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -151 lines) Patch
M bin/devrun.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/runtime/dart/_debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/_runtime.js View 4 chunks +9 lines, -9 lines 0 comments Download
M lib/runtime/dart/async.js View 10 chunks +30 lines, -30 lines 0 comments Download
M lib/runtime/dart/collection.js View 12 chunks +17 lines, -17 lines 0 comments Download
M lib/runtime/dart/convert.js View 11 chunks +22 lines, -22 lines 0 comments Download
M lib/runtime/dart/html.js View 4 chunks +11 lines, -11 lines 0 comments Download
M lib/runtime/dart/html_common.js View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/runtime/dart/isolate.js View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/codegen/js_printer.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M lib/src/js/nodes.dart View 2 chunks +0 lines, -8 lines 0 comments Download
M lib/src/js/printer.dart View 4 chunks +1 line, -17 lines 0 comments Download
M lib/src/options.dart View 4 chunks +0 lines, -8 lines 0 comments Download
M test/codegen/expect/collection/src/wrappers.txt View 1 chunk +1 line, -1 line 0 comments Download
M tool/build_sdk.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/node_test.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jennifer Messerly
4 years, 10 months ago (2016-01-29 23:25:35 UTC) #2
vsm
On 2016/01/29 23:25:35, John Messerly wrote: Atom is still on Chrome 45. Do you know ...
4 years, 10 months ago (2016-01-30 00:44:41 UTC) #3
Jennifer Messerly
On 2016/01/30 00:44:41, vsm wrote: > On 2016/01/29 23:25:35, John Messerly wrote: > > Atom ...
4 years, 10 months ago (2016-02-01 19:32:44 UTC) #4
Jennifer Messerly
On 2016/02/01 19:32:44, John Messerly wrote: > On 2016/01/30 00:44:41, vsm wrote: > > On ...
4 years, 10 months ago (2016-02-01 20:07:39 UTC) #5
vsm
lgtm
4 years, 10 months ago (2016-02-01 20:31:09 UTC) #6
Jennifer Messerly
4 years, 10 months ago (2016-02-01 20:55:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
22e01a24224ee0af2a1bd937570f3f9dd6e2f83d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698