Reverts fdca07 and makes it possible to force absolute paths.

Reverts fdca07 and makes it possible to force absolute paths.

Explicitly: This reverts the patch that reverted the patch that
removed the majority of absolute paths from linux builds, and makes
it possible to use an absolute path by setting dont_embed_build_metadata
to false.

In conjunction with codereview.chromium.org/1642193002 that modifies the codesearch
buildbot to use dont_embed_build_metadata = false, this CL should allow
codesearch to continue working, and all other buildbots and users
to gain the benefits of not requiring absolute paths.

BUG=580103
Committed: https://crrev.com/4b6f030a35226c0d6e412b1025e791e5391b1455
Cr-Commit-Position: refs/heads/master@{#373432}

[Zachary Forman, 2016-01-28 20:59:54]

Description was changed from

==========
Reverts fdca07 and makes it possible to force absolute paths.

Explicitly: This reverts the patch that reverted the patch that
removed the majority of absolute paths from linux builds, and makes
it possible to use an absolute path by setting dont_embed_build_metadata
to false.

In conjunction with [infra CL] that modifies the codesearch
buildbot to use dont_embed_build_metadata = false, this CL should allow
codesearch to continue working, and all other buildbots and users
to gain the benefits of not requiring absolute paths.

BUG=580103
==========

to

==========
Reverts fdca07 and makes it possible to force absolute paths.

Explicitly: This reverts the patch that reverted the patch that
removed the majority of absolute paths from linux builds, and makes
it possible to use an absolute path by setting dont_embed_build_metadata
to false.

In conjunction with 1642193002 that modifies the codesearch
buildbot to use dont_embed_build_metadata = false, this CL should allow
codesearch to continue working, and all other buildbots and users
to gain the benefits of not requiring absolute paths.

BUG=580103
==========

[Zachary Forman, 2016-01-28 22:35:19]

Description was changed from

==========
Reverts fdca07 and makes it possible to force absolute paths.

Explicitly: This reverts the patch that reverted the patch that
removed the majority of absolute paths from linux builds, and makes
it possible to use an absolute path by setting dont_embed_build_metadata
to false.

In conjunction with 1642193002 that modifies the codesearch
buildbot to use dont_embed_build_metadata = false, this CL should allow
codesearch to continue working, and all other buildbots and users
to gain the benefits of not requiring absolute paths.

BUG=580103
==========

to

==========
Reverts fdca07 and makes it possible to force absolute paths.

Explicitly: This reverts the patch that reverted the patch that
removed the majority of absolute paths from linux builds, and makes
it possible to use an absolute path by setting dont_embed_build_metadata
to false.

In conjunction with codereview.chromium.org/1642193002 that modifies the
codesearch
buildbot to use dont_embed_build_metadata = false, this CL should allow
codesearch to continue working, and all other buildbots and users
to gain the benefits of not requiring absolute paths.

BUG=580103
==========

[Zachary Forman, 2016-01-28 23:01:52]

zforman@google.com changed reviewers:
+ dsansome@chromium.org, maruel@chromium.org, thakis@chromium.org

[Zachary Forman, 2016-01-28 23:01:52]

Hey all, could you please take a look at this CL?

It's a revert-of-a-revert + a small change, and coupled with the buildbot CL
you're also all CC'd on should fix the codesearch issue (based on local testing)
while still leaving the benefits of my previous CL for practically all other
purposes.

[dsansome, 2016-01-28 23:18:59]

lgtm

[M-A Ruel, 2016-01-29 01:20:29]

generally, it's preferable to revert, upload as patchset #1, then fix, then
upload as patchset #2, so the diff is easy to see. But I could see the comment
about codesearch so lgtm.

[Zachary Forman, 2016-01-29 02:25:06]

On 2016/01/29 at 01:20:29, maruel wrote:
> generally, it's preferable to revert, upload as patchset #1, then fix, then
upload as patchset #2, so the diff is easy to see. But I could see the comment
about codesearch so lgtm.

Acknowledged - I'll keep that in mind for the future :)

[Zachary Forman, 2016-02-01 20:57:03]

The CQ bit was checked by zforman@google.com

[commit-bot: I haz the power, 2016-02-01 20:58:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643523004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643523004/1

[commit-bot: I haz the power, 2016-02-01 21:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-01 21:05:53]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zachary Forman, 2016-02-02 03:13:33]

So, this build previously failed on gn, as it assumed that is_official_build was
defined. As I had set it on / off via gn args, it /was/ defined while testing
locally.

I've added a change (patchsets 2 and 3) that split out dont_embed_build_metadata
into a new file, build_metadata.gni.

Please take another look :).

[M-A Ruel, 2016-02-02 05:12:45]

lgtm

[Zachary Forman, 2016-02-02 06:02:36]

The CQ bit was checked by zforman@google.com

[Zachary Forman, 2016-02-02 06:02:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsansome@chromium.org
Link to the patchset: https://codereview.chromium.org/1643523004/#ps40001
(title: "Adds missing dependency")

[commit-bot: I haz the power, 2016-02-02 06:07:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643523004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643523004/40001

[commit-bot: I haz the power, 2016-02-02 06:17:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 06:17:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Zachary Forman, 2016-02-02 06:27:18]

On 2016/02/02 at 06:17:08, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Oops - failed to realise that this CL still needs an LGTM from Nico for OWNER
check :).

[Nico, 2016-02-03 23:40:58]

comparing diffs, it looks like this is a tweaked _reland_ of
https://codereview.chromium.org/1556923002/ . is that correct? if so, for the
future: the best way to do this is to upload the original change as patch set 1,
and then the changed version as patch set 2. that way, it's easy to see what
changed.

lgtm, but as I told maruel long ago, long-term I think the best way is to add
some compiler flags to clang that make __FILE__ and __DATE__ and so on
deterministic in the compiler, and then pass those

[Zachary Forman, 2016-02-03 23:49:10]

zforman@google.com changed reviewers:
+ brettw@chromium.org

[Zachary Forman, 2016-02-03 23:49:11]

+brettw@chromium.org for printing/BUILD.gn.

Hi Brett, this is a modification to the previous CL that rendered the sysroot a
relative path (https://codereview.chromium.org/1556923002) that allows the
sysroot to be forced back to an absolute path if required, with the addition of
splitting out dont_embed_build_metadata into its own .gni file.

Please take a look :)

Thanks,
Zac

[brettw, 2016-02-03 23:59:47]

lgtm

[Zachary Forman, 2016-02-04 02:11:45]

The CQ bit was checked by zforman@google.com

[commit-bot: I haz the power, 2016-02-04 02:13:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643523004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643523004/40001

[commit-bot: I haz the power, 2016-02-04 02:23:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-04 02:24:41]

Description was changed from

==========
Reverts fdca07 and makes it possible to force absolute paths.

Explicitly: This reverts the patch that reverted the patch that
removed the majority of absolute paths from linux builds, and makes
it possible to use an absolute path by setting dont_embed_build_metadata
to false.

In conjunction with codereview.chromium.org/1642193002 that modifies the
codesearch
buildbot to use dont_embed_build_metadata = false, this CL should allow
codesearch to continue working, and all other buildbots and users
to gain the benefits of not requiring absolute paths.

BUG=580103
==========

to

==========
Reverts fdca07 and makes it possible to force absolute paths.

Explicitly: This reverts the patch that reverted the patch that
removed the majority of absolute paths from linux builds, and makes
it possible to use an absolute path by setting dont_embed_build_metadata
to false.

In conjunction with codereview.chromium.org/1642193002 that modifies the
codesearch
buildbot to use dont_embed_build_metadata = false, this CL should allow
codesearch to continue working, and all other buildbots and users
to gain the benefits of not requiring absolute paths.

BUG=580103

Committed: https://crrev.com/4b6f030a35226c0d6e412b1025e791e5391b1455
Cr-Commit-Position: refs/heads/master@{#373432}
==========

[commit-bot: I haz the power, 2016-02-04 02:24:42]

Patchset 3 (id:??) landed as
https://crrev.com/4b6f030a35226c0d6e412b1025e791e5391b1455
Cr-Commit-Position: refs/heads/master@{#373432}