Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1643523003: Add catapult/third_party/coverage to check_licenses test. (Closed)

Created:
4 years, 11 months ago by sullivan
Modified:
4 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, dtu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add catapult/third_party/coverage to check_licenses test. Committed: https://crrev.com/364b0f4a02d34094e02741055c465cb4f0471d63 Cr-Commit-Position: refs/heads/master@{#371802}

Patch Set 1 #

Total comments: 1

Patch Set 2 : UNKNOWN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/checklicenses/checklicenses.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
sullivan
4 years, 11 months ago (2016-01-27 15:53:48 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/1643523003/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/1643523003/diff/1/tools/checklicenses/checklicenses.py#newcode40 tools/checklicenses/checklicenses.py:40: 'Apache (v2.0)', Wait, Apache is already whitelisted here, globally. ...
4 years, 11 months ago (2016-01-27 15:55:40 UTC) #3
sullivan
On 2016/01/27 15:55:40, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/1643523003/diff/1/tools/checklicenses/checklicenses.py > File tools/checklicenses/checklicenses.py (right): > > ...
4 years, 11 months ago (2016-01-27 15:56:53 UTC) #4
Paweł Hajdan Jr.
On 2016/01/27 at 15:56:53, sullivan wrote: > I'm sorry, not familiar with the file format ...
4 years, 11 months ago (2016-01-27 15:57:58 UTC) #5
sullivan
On 2016/01/27 15:57:58, Paweł Hajdan Jr. wrote: > On 2016/01/27 at 15:56:53, sullivan wrote: > ...
4 years, 11 months ago (2016-01-27 15:59:25 UTC) #6
Paweł Hajdan Jr.
LGTM
4 years, 11 months ago (2016-01-27 16:00:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643523003/20001
4 years, 11 months ago (2016-01-27 16:02:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 16:34:22 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 16:35:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/364b0f4a02d34094e02741055c465cb4f0471d63
Cr-Commit-Position: refs/heads/master@{#371802}

Powered by Google App Engine
This is Rietveld 408576698