Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1643513002: Catch exception when creating device log entries (Closed)

Created:
4 years, 11 months ago by François Beaufort
Modified:
4 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch exception when creating device log entries Committed: https://crrev.com/2fe78b441548411fa343e5215fa54cf63212d739 Cr-Commit-Position: refs/heads/master@{#372060}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added No log entries to container #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/resources/device_log_ui/device_log_ui.js View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
fbeaufortchromium
If there are no log entries, this fails to parse JSON object as it returns ...
4 years, 11 months ago (2016-01-27 11:57:00 UTC) #2
stevenjb
lgtm https://codereview.chromium.org/1643513002/diff/1/chrome/browser/resources/device_log_ui/device_log_ui.js File chrome/browser/resources/device_log_ui/device_log_ui.js (right): https://codereview.chromium.org/1643513002/diff/1/chrome/browser/resources/device_log_ui/device_log_ui.js#newcode100 chrome/browser/resources/device_log_ui/device_log_ui.js:100: } catch(e) {} This is fine as-is, but ...
4 years, 11 months ago (2016-01-27 18:13:08 UTC) #3
fbeaufortchromium
On 2016/01/27 18:13:08, stevenjb wrote: > lgtm > > https://codereview.chromium.org/1643513002/diff/1/chrome/browser/resources/device_log_ui/device_log_ui.js > File chrome/browser/resources/device_log_ui/device_log_ui.js (right): > ...
4 years, 10 months ago (2016-01-28 09:06:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643513002/20001
4 years, 10 months ago (2016-01-28 09:07:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 09:52:12 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 09:53:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fe78b441548411fa343e5215fa54cf63212d739
Cr-Commit-Position: refs/heads/master@{#372060}

Powered by Google App Engine
This is Rietveld 408576698